From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Cc: bfields@fieldses.org, yamada.masahiro@socionext.com,
michal.lkml@markovi.net, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: prune-kernel:remove old kernels and modules dir from system
Date: Wed, 30 Oct 2019 22:27:19 -0700 [thread overview]
Message-ID: <809aa850-7a22-a7c5-af21-0e88d1c63dd7@infradead.org> (raw)
In-Reply-To: <20191031045242.GA3130@Gentoo>
On 10/30/19 9:52 PM, Bhaskar Chowdhury wrote:
>>>> That 'rm' doesn't remove any files. Compare what remove_old_kernel() does.
>>> No,it is not using that function rather take the parameter from the
>>> commandline and get into boot dir match with it and remove it.
>>
>> But it doesn't do that. I tested it. It should be more like what
>> rmeove_old_kernel() does:
>>
>> rm -If vmlinuz-$kernel_ver System.map-$kernel_ver config-$kernel_ver
>>
>> and if not, please explain why not.
> Okay, again some uniformity missing in the code, I would like to your
> suggested method,i.e call remove_old_kernel to do the job instead of depending on individual kernel.
The simplest thing to do is set kernel_version=$kernel_ver
and then call remove_old_kernel().
And set modules_version=$modules_dir_name and call remove_old_modules_dir().
But it would be cleaner to pass a parameter (kernel_version) to the
remove_old_kernel() function and to pass a parameter (modules_dir) to the
remove_old_modules_dir() function.
--
~Randy
next prev parent reply other threads:[~2019-10-31 5:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 9:54 [PATCH] scripts: prune-kernel:remove old kernels and modules dir from system Bhaskar Chowdhury
2019-10-31 2:33 ` Randy Dunlap
2019-10-31 3:37 ` Bhaskar Chowdhury
2019-10-31 4:32 ` Randy Dunlap
2019-10-31 4:52 ` Bhaskar Chowdhury
2019-10-31 5:27 ` Randy Dunlap [this message]
2019-10-31 7:18 ` Bhaskar Chowdhury
2019-10-31 15:06 ` Randy Dunlap
2019-11-01 4:23 ` Bhaskar Chowdhury
2019-11-01 5:11 ` Bhaskar Chowdhury
2019-11-01 5:45 ` Randy Dunlap
2019-11-02 6:30 [PATCH] scripts:prune-kernel:remove " Bhaskar Chowdhury
2019-11-05 2:03 ` Randy Dunlap
2019-11-05 2:32 ` J. Bruce Fields
2019-11-05 4:39 ` Bhaskar Chowdhury
2019-11-05 4:52 ` Bhaskar Chowdhury
2019-11-06 2:53 ` Masahiro Yamada
2019-11-06 3:10 ` Bhaskar Chowdhury
2019-11-06 4:03 ` Masahiro Yamada
2019-11-06 4:29 ` Bhaskar Chowdhury
2019-11-06 4:31 ` J. Bruce Fields
2019-11-06 4:32 ` Randy Dunlap
2019-11-06 4:42 ` Bhaskar Chowdhury
2019-11-06 19:30 ` J. Bruce Fields
2019-11-06 22:39 ` Bhaskar Chowdhury
2019-11-09 7:25 ` Masahiro Yamada
2019-11-09 11:13 ` Bhaskar Chowdhury
2019-11-15 1:58 ` Masahiro Yamada
2019-11-15 15:21 ` Bhaskar Chowdhury
2019-11-18 7:30 ` Masahiro Yamada
2019-11-05 4:33 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=809aa850-7a22-a7c5-af21-0e88d1c63dd7@infradead.org \
--to=rdunlap@infradead.org \
--cc=bfields@fieldses.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=unixbhaskar@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.