From: Sven Strickroth <email@cs-ware.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] Don't pass -v to submodule command
Date: Thu, 1 Dec 2022 09:32:09 +0100 [thread overview]
Message-ID: <80d5eb7c-c668-d325-2aaa-cbee742d1f15@cs-ware.de> (raw)
In-Reply-To: <221130.868rjsi6bn.gmgdl@evledraar.gmail.com>
Am 30.11.2022 um 20:17 schrieb Ævar Arnfjörð Bjarmason:
>> --- a/builtin/pull.c
>> +++ b/builtin/pull.c
>> @@ -256,7 +256,7 @@ static struct option pull_options[] = {
>> /**
>> * Pushes "-q" or "-v" switches into arr to match the opt_verbosity level.
>> */
>> -static void argv_push_verbosity(struct strvec *arr)
>> +static void argv_push_verbosity(struct strvec *arr, int include_v)
>> {
>> int verbosity;
>>
>
> It looks like you're getting somewhere with this, but you never use this
> "include_v", so the bug is still there. We just have the scaffolding
> now.
>
> Did you forget to add that part to this commit?
Opps, seems so.
> In any case, that serves as a comment on the other thing this patch
> really needs: tests, please add some.
I don't know how to add tests and don't have a fully fledged build
environment for git here.
--
Best regards,
Sven Strickroth
PGP key id F5A9D4C4 @ any key-server
next prev parent reply other threads:[~2022-12-01 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 12:47 git pull --verbose with submodules ends in error message Fink, Mike
2022-11-25 15:56 ` Sven Strickroth
2022-11-30 18:30 ` [PATCH] Don't pass -v to submodule command Sven Strickroth
2022-11-30 19:17 ` Ævar Arnfjörð Bjarmason
2022-12-01 8:32 ` Sven Strickroth [this message]
2022-12-01 8:34 ` [PATCH v2] " Sven Strickroth
2022-12-02 0:24 ` [PATCH] " Junio C Hamano
2022-12-10 13:06 ` [PATCH] submodule: Accept -v for update command Sven Strickroth
2022-12-18 1:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80d5eb7c-c668-d325-2aaa-cbee742d1f15@cs-ware.de \
--to=email@cs-ware.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.