From: Dave Hansen <dave.hansen@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
nitesh@redhat.com, kvm@vger.kernel.org, david@redhat.com,
mst@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Cc: yang.zhang.wz@gmail.com, pagupta@redhat.com, riel@surriel.com,
konrad.wilk@oracle.com, lcapitulino@redhat.com,
wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com
Subject: Re: [PATCH v1 3/6] mm: Use zone and order instead of free area in free_list manipulators
Date: Tue, 25 Jun 2019 11:36:02 -0700 [thread overview]
Message-ID: <810257c3-216a-d029-9360-508a9aa8c2dd@intel.com> (raw)
In-Reply-To: <20190619223316.1231.50329.stgit@localhost.localdomain>
On 6/19/19 3:33 PM, Alexander Duyck wrote:
> - move_to_free_area(page, &zone->free_area[order], migratetype);
> + move_to_free_area(page, zone, order, migratetype);
This certainly looks nicer. But the naming is a bit goofy now because
you're talking about free areas, but there's no free area to be seen.
If anything, isn't it moving to a free_list[]? It's actually going to
zone->free_area[]->free_list[], so the free area seems rather
inconsequential in the entire thing. The (zone/order/migratetype)
combination specifies a free_list[] not a free area anyway.
next prev parent reply other threads:[~2019-06-25 18:36 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 22:32 [PATCH v1 0/6] mm / virtio: Provide support for paravirtual waste page treatment Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-06-25 7:55 ` David Hildenbrand
2019-06-28 19:49 ` Alexander Duyck
2019-06-28 19:49 ` Alexander Duyck
2019-06-25 18:25 ` Dave Hansen
2019-06-25 18:26 ` Dave Hansen
2019-06-19 22:33 ` [PATCH v1 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-06-25 18:28 ` Dave Hansen
2019-06-28 19:55 ` Alexander Duyck
2019-06-28 19:55 ` Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-06-25 18:36 ` Dave Hansen [this message]
2019-06-19 22:33 ` [PATCH v1 4/6] mm: Introduce "aerated" pages Alexander Duyck
2019-06-25 19:45 ` Dave Hansen
2019-07-08 17:32 ` Alexander Duyck
2019-07-08 17:32 ` Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 5/6] mm: Add logic for separating "aerated" pages from "raw" pages Alexander Duyck
2019-06-25 20:24 ` Dave Hansen
2019-07-08 19:02 ` Alexander Duyck
2019-07-08 19:02 ` Alexander Duyck
2019-07-08 19:36 ` Dave Hansen
2019-07-08 22:02 ` Alexander Duyck
2019-07-08 22:02 ` Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting Alexander Duyck
2019-07-16 9:55 ` Michael S. Tsirkin
2019-07-16 14:00 ` Dave Hansen
2019-07-16 14:12 ` David Hildenbrand
2019-07-16 14:17 ` David Hildenbrand
2019-07-16 15:04 ` Michael S. Tsirkin
2019-07-16 14:41 ` Dave Hansen
2019-07-16 15:01 ` Wang, Wei W
2019-07-16 15:01 ` Wang, Wei W
2019-07-16 16:12 ` Michael S. Tsirkin
2019-07-16 16:12 ` Michael S. Tsirkin
2019-07-16 15:02 ` David Hildenbrand
2019-07-16 15:37 ` Alexander Duyck
2019-07-16 15:37 ` Alexander Duyck
2019-07-16 16:07 ` Michael S. Tsirkin
2019-07-16 16:54 ` Alexander Duyck
2019-07-16 16:54 ` Alexander Duyck
2019-07-16 17:41 ` Michael S. Tsirkin
2019-07-16 21:06 ` Alexander Duyck
2019-07-16 21:06 ` Alexander Duyck
2019-07-17 10:28 ` Michael S. Tsirkin
2019-07-17 16:43 ` Alexander Duyck
2019-07-17 16:43 ` Alexander Duyck
2019-07-18 5:13 ` Michael S. Tsirkin
2019-07-18 15:34 ` Alexander Duyck
2019-07-18 15:34 ` Alexander Duyck
2019-07-18 16:03 ` Nitesh Narayan Lal
2019-07-18 20:27 ` Michael S. Tsirkin
2019-07-18 16:07 ` Michael S. Tsirkin
2019-07-18 20:29 ` Alexander Duyck
2019-07-18 20:29 ` Alexander Duyck
2019-07-18 20:37 ` Michael S. Tsirkin
2019-07-18 20:54 ` Alexander Duyck
2019-07-18 20:54 ` Alexander Duyck
2019-07-18 20:24 ` Michael S. Tsirkin
2019-07-18 20:34 ` Alexander Duyck
2019-07-18 20:34 ` Alexander Duyck
2019-07-18 20:48 ` Michael S. Tsirkin
2019-07-18 21:09 ` Alexander Duyck
2019-07-18 21:09 ` Alexander Duyck
2019-06-19 22:37 ` [PATCH v1 QEMU] QEMU: Provide a interface for hinting based off of the balloon infrastructure Alexander Duyck
2019-06-25 7:42 ` [PATCH v1 0/6] mm / virtio: Provide support for paravirtual waste page treatment David Hildenbrand
2019-06-25 14:10 ` Dave Hansen
2019-06-25 17:00 ` Alexander Duyck
2019-06-25 17:00 ` Alexander Duyck
2019-06-25 18:12 ` David Hildenbrand
2019-06-25 18:22 ` Dave Hansen
2019-07-15 9:41 ` David Hildenbrand
2019-07-15 14:57 ` Alexander Duyck
2019-07-15 14:57 ` Alexander Duyck
2019-06-25 16:09 ` Alexander Duyck
2019-06-25 16:09 ` Alexander Duyck
2019-06-26 9:01 ` Christophe de Dinechin
2019-06-26 9:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=810257c3-216a-d029-9360-508a9aa8c2dd@intel.com \
--to=dave.hansen@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.