From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] [broken] meson: try link tracepoints to module
Date: Fri, 20 Nov 2020 13:30:41 +0100 [thread overview]
Message-ID: <8102f2fa-1902-050d-d6c4-cd2bc80c7cb5@redhat.com> (raw)
In-Reply-To: <20201120112539.bsyjsfrqxz4ffo4r@sirius.home.kraxel.org>
On 11/20/20 12:25 PM, Gerd Hoffmann wrote:
> Hi,
>
>> Guess I'll go dig into the meson documentation, this looks more like a
>> build system than a tracing problem to me.
>
> Looking at https://mesonbuild.com/Syntax.html ...
>
> "all objects are immutable".
>
> So "var2 = var1" creates a copy not a reference I guess?
>
> Which implies that ...
>
> foo_ss.add(something)
>
> ... is different from ...
>
> bar_ss = foo_ss
> bar_ss.add(something)
>
> ... which in turn explains why the patch doesn't work at all.
>
> Now I'm wondering how I can make trace/meson.build add the trace
> objects to the module source sets if I can't pass around references
> to the module source sets?
>
> Paolo? Any hints how to tackle this the meson way?
Maybe managing it all in the main meson.build, like the
e28ab096bf8..da33fc09873 cleanup?
("Move the creation of the library to the main meson.build")
>
> thanks,
> Gerd
>
>
next prev parent reply other threads:[~2020-11-20 12:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 8:44 [PATCH 0/4] [RfC] try fix tracing for modules Gerd Hoffmann
2020-11-19 8:44 ` [PATCH 1/4] meson: add trace_events_config[] Gerd Hoffmann
2020-11-19 9:50 ` Stefan Hajnoczi
2020-11-19 8:44 ` [PATCH 2/4] meson: move up hw subdir (specifically before trace subdir) Gerd Hoffmann
2020-11-19 10:01 ` Stefan Hajnoczi
2020-11-19 8:44 ` [PATCH 3/4] meson: move qxl trace events to separate file Gerd Hoffmann
2020-11-19 9:33 ` Daniel P. Berrangé
2020-11-19 10:06 ` Stefan Hajnoczi
2020-11-19 10:25 ` Gerd Hoffmann
2020-11-19 8:44 ` [PATCH 4/4] [broken] meson: try link tracepoints to module Gerd Hoffmann
2020-11-19 11:03 ` Stefan Hajnoczi
2020-11-19 11:23 ` Gerd Hoffmann
2020-11-19 11:55 ` Stefan Hajnoczi
2020-11-20 10:23 ` Gerd Hoffmann
2020-11-20 11:25 ` Gerd Hoffmann
2020-11-20 12:30 ` Philippe Mathieu-Daudé [this message]
2020-11-20 13:06 ` Paolo Bonzini
2020-11-20 13:15 ` Gerd Hoffmann
2020-11-20 13:05 ` Paolo Bonzini
2020-11-23 11:38 ` Gerd Hoffmann
2020-11-23 13:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8102f2fa-1902-050d-d6c4-cd2bc80c7cb5@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.