Re: [cip-dev] [isar-cip-core RFC 6/7] swupdate: Add luahandler for secureboot

From: "Quirin Gylstorff" <quirin.gylstorff@siemens.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, cip-dev@lists.cip-project.org
Subject: Re: [cip-dev] [isar-cip-core RFC 6/7] swupdate: Add luahandler for secureboot
Date: Mon, 29 Jun 2020 11:01:32 +0200	[thread overview]
Message-ID: <81a7b2f1-c80a-9397-92e2-44b6e0d8e500@siemens.com> (raw)
In-Reply-To: <7e9f03be-1cc3-48be-98bf-c0b8b1692c7a@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On 6/29/20 10:14 AM, Jan Kiszka wrote:
> On 25.06.20 16:10, Q. Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   recipes-core/swupdate/files/swupdate_handlers.lua | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-core/swupdate/files/swupdate_handlers.lua 
>> b/recipes-core/swupdate/files/swupdate_handlers.lua
>> index c9b9962..f2ecc54 100644
>> --- a/recipes-core/swupdate/files/swupdate_handlers.lua
>> +++ b/recipes-core/swupdate/files/swupdate_handlers.lua
>> @@ -311,8 +311,12 @@ function handler_roundrobin(image)
>>           if rootparam and rootdevice then break end
>>       end
>>       if not rootdevice then
>> -      swupdate.error("Cannot determine current root device.")
>> -      return 1
>> +        -- Use findmnt to get the rootdev
>> +      rootdevice = io.popen('findmnt -nl / -o PARTUUID'):read("*l")
>> +      if not rootdevice then
>> +        swupdate.error("Cannot determine current root device.")
>> +        return 1
>> +      end
>>       end
>>       swupdate.info(string.format("Current root device is: %s", 
>> rootdevice))
>>
> 
> Seems not really specific to secure-boot, rather related to the 
> initramfs-based rootfs selection. But is that one actually using 
> PARTUUID in the end? Or rather device paths?

it uses the partuuid from root. If someone finds a better way to get
the current root without parsing the  kernel commandline I would use
that.
> 
> Anyway, I'm not against merging this. It should just be correctly 
> labeled. Or maybe even merged into the swupdate patch from the first 
> series.

I move the patch to the a/b update patch.

> 
> Jan
> 

-- 
Quirin

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4848): https://lists.cip-project.org/g/cip-dev/message/4848
Mute This Topic: https://lists.cip-project.org/mt/75103454/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-