From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "fukuri.sai@gmail.com" <fukuri.sai@gmail.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "qi.fuli@fujitsu.com" <qi.fuli@fujitsu.com>
Subject: Re: [ndctl PATCH 1/2] configure: add checking jq command
Date: Wed, 10 Mar 2021 09:10:23 +0000 [thread overview]
Message-ID: <81d1a4aee1de0ae916725c6799e921c0132d37c2.camel@intel.com> (raw)
In-Reply-To: <20210301172540.1511-1-qi.fuli@fujitsu.com>
On Tue, 2021-03-02 at 02:25 +0900, QI Fuli wrote:
> Add checking jq command since it is needed to validate tests
>
> Cc: Santosh Sivaraj <santosh@fossix.org>
> Signed-off-by: QI Fuli <qi.fuli@fujitsu.com>
> Link: https://github.com/pmem/ndctl/issues/141
> ---
> configure.ac | 6 ++++++
> 1 file changed, 6 insertions(+)
Hm, I think I prefer how you did it in v1. i.e. no configure.ac check.
In my view, configure.ac tests are for the core things needed to /run/
ndctl on a system. Development unit tests can just continue to use
check_prereq as you did. So I'll pick up v1 of this for now - if you
want me to do something else please let me know!
>
> diff --git a/configure.ac b/configure.ac
> index 5ec8d2f..839836b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -65,6 +65,12 @@ fi
> AC_SUBST([XMLTO])
> fi
>
> +AC_CHECK_PROG(JQ, [jq], [$(which jq)], [missing])
> +if test "x$JQ" = xmissing; then
> + AC_MSG_ERROR([jq command needed to validate tests])
> +fi
> +AC_SUBST([JQ])
> +
> AC_C_TYPEOF
> AC_DEFINE([HAVE_STATEMENT_EXPR], 1, [Define to 1 if you have statement expressions.])
>
> --
> 2.29.2
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2021-03-10 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 17:25 [ndctl PATCH 1/2] configure: add checking jq command QI Fuli
2021-03-01 17:25 ` [ndctl PATCH 2/2] ndctl/test: add checking the presence of jq command ahead QI Fuli
2021-03-02 5:20 ` Santosh Sivaraj
2021-03-02 5:15 ` [ndctl PATCH 1/2] configure: add checking jq command Santosh Sivaraj
2021-03-10 9:10 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d1a4aee1de0ae916725c6799e921c0132d37c2.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=fukuri.sai@gmail.com \
--cc=linux-nvdimm@lists.01.org \
--cc=qi.fuli@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.