From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
armbru@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH v9 1/3] block: introduce compress filter driver
Date: Tue, 26 Nov 2019 09:51:38 -0600 [thread overview]
Message-ID: <81e8a576-8611-749a-9aa5-e35025de6cd6@redhat.com> (raw)
In-Reply-To: <1574779398-88772-2-git-send-email-andrey.shinkevich@virtuozzo.com>
On 11/26/19 8:43 AM, Andrey Shinkevich wrote:
> Allow writing all the data compressed through the filter driver.
> The written data will be aligned by the cluster size.
> Based on the QEMU current implementation, that data can be written to
> unallocated clusters only. May be used for a backup job.
>
> Suggested-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
> +++ b/qapi/block-core.json
> @@ -2884,15 +2884,16 @@
> # @copy-on-read: Since 3.0
> # @blklogwrites: Since 3.0
> # @blkreplay: Since 4.2
> +# @compress: Since 5.0
> #
> # Since: 2.9
> ##
> { 'enum': 'BlockdevDriver',
> 'data': [ 'blkdebug', 'blklogwrites', 'blkreplay', 'blkverify', 'bochs',
> - 'cloop', 'copy-on-read', 'dmg', 'file', 'ftp', 'ftps', 'gluster',
> - 'host_cdrom', 'host_device', 'http', 'https', 'iscsi', 'luks',
> - 'nbd', 'nfs', 'null-aio', 'null-co', 'nvme', 'parallels', 'qcow',
> - 'qcow2', 'qed', 'quorum', 'raw', 'rbd',
> + 'cloop', 'copy-on-read', 'compress', 'dmg', 'file', 'ftp', 'ftps',
Nit: Preserving alphabetical ordering means 'compress' comes before
'copy-on-read'.
> + 'gluster', 'host_cdrom', 'host_device', 'http', 'https', 'iscsi',
> + 'luks', 'nbd', 'nfs', 'null-aio', 'null-co', 'nvme', 'parallels',
> + 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rbd',
> { 'name': 'replication', 'if': 'defined(CONFIG_REPLICATION)' },
> 'sheepdog',
> 'ssh', 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] }
> @@ -4045,6 +4046,7 @@
> 'bochs': 'BlockdevOptionsGenericFormat',
> 'cloop': 'BlockdevOptionsGenericFormat',
> 'copy-on-read':'BlockdevOptionsGenericFormat',
> + 'compress': 'BlockdevOptionsGenericFormat',
and again
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-11-26 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 14:43 [PATCH v9 0/3] qcow2: advanced compression options Andrey Shinkevich
2019-11-26 14:43 ` [PATCH v9 1/3] block: introduce compress filter driver Andrey Shinkevich
2019-11-26 15:51 ` Eric Blake [this message]
2019-11-27 14:01 ` Max Reitz
2019-11-26 14:43 ` [PATCH v9 2/3] qcow2: Allow writing compressed data of multiple clusters Andrey Shinkevich
2019-11-27 14:52 ` Max Reitz
2019-11-26 14:43 ` [PATCH v9 3/3] tests/qemu-iotests: add case to write " Andrey Shinkevich
2019-11-27 15:17 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81e8a576-8611-749a-9aa5-e35025de6cd6@redhat.com \
--to=eblake@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.