Re: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration

From: Chuck Lever III <chuck.lever@oracle.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
	Anna Schumaker <anna.schumaker@netapp.com>
Cc: Bruce Fields <bfields@fieldses.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	"kael_w@yeah.net" <kael_w@yeah.net>
Subject: Re: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration
Date: Thu, 1 Apr 2021 13:32:47 +0000	[thread overview]
Message-ID: <82C3737A-E6CA-469E-B159-85DBE3657221@oracle.com> (raw)
In-Reply-To: <20210401095658.1006341-1-wanjiabing@vivo.com>

Hi -

> On Apr 1, 2021, at 5:56 AM, Wan Jiabing <wanjiabing@vivo.com> wrote:
> 
> struct rpcrdma_req is declared twice. One is declared at 216th line.
> The blew one is not needed. Remove the duplicate.

s/blew/below/

> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

Thanks! This one goes to Anna.

> ---
> net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> index fe3be985e239..11e5fbfc642c 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -239,7 +239,6 @@ struct rpcrdma_frwr {
> 	};
> };
> 
> -struct rpcrdma_req;
> struct rpcrdma_mr {
> 	struct list_head	mr_list;
> 	struct rpcrdma_req	*mr_req;
> -- 
> 2.25.1
> 

--
Chuck Lever