From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Taniya Das <tdas@qti.qualcomm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-media@vger.kernel.org,
Jagadeesh Kona <quic_jkona@quicinc.com>
Subject: Re: [PATCH RESEND v3 4/5] clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode
Date: Tue, 7 Nov 2023 22:21:15 +0100 [thread overview]
Message-ID: <82a25b12-7a63-4c75-8a46-624bc35c6752@linaro.org> (raw)
In-Reply-To: <835a6add-81e9-42e4-abbe-91632aaa6bc9@linaro.org>
On 11/7/23 14:05, Bryan O'Donoghue wrote:
> On 01/11/2023 09:04, Abel Vesa wrote:
>> From: Jagadeesh Kona <quic_jkona@quicinc.com>
>>
>> The current HW_CTRL flag switches the video GDSC to HW control mode as
>> part of GDSC enable itself, instead of that use HW_CTRL_TRIGGER flag to
>> give consumer drivers more control and switch the GDSC mode as and when
>> required.
>>
>> HW_CTRL_TRIGGER flag allows consumer drivers to switch the video GDSC to
>> HW/SW control modes at runtime using dev_pm_genpd_set_hwmode API.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>> drivers/clk/qcom/videocc-sc7180.c | 2 +-
>> drivers/clk/qcom/videocc-sc7280.c | 2 +-
>> drivers/clk/qcom/videocc-sdm845.c | 4 ++--
>> drivers/clk/qcom/videocc-sm8250.c | 4 ++--
>> drivers/clk/qcom/videocc-sm8550.c | 4 ++--
>> 5 files changed, 8 insertions(+), 8 deletions(-)
>
> So.
>
> I'm assuming the rest of this series works however for sc8250 at least this is a NAK, breaks venus on rb5.
Are you saying that applying this patch alone causes the attached crash?
Konrad
next prev parent reply other threads:[~2023-11-07 21:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 9:04 [PATCH RESEND v3 0/5] PM: domains: Add control for switching back and forth to HW control Abel Vesa
2023-11-01 9:04 ` [PATCH RESEND v3 1/5] PM: domains: Allow devices attached to genpd to be managed by HW Abel Vesa
2023-11-01 21:26 ` Dmitry Baryshkov
2023-11-03 19:46 ` Bjorn Andersson
2023-11-01 9:04 ` [PATCH RESEND v3 2/5] PM: domains: Add the domain HW-managed mode to the summary Abel Vesa
2023-11-01 21:26 ` Dmitry Baryshkov
2023-11-03 19:47 ` Bjorn Andersson
2023-11-01 9:04 ` [PATCH RESEND v3 3/5] clk: qcom: gdsc: Add set and get hwmode callbacks to switch GDSC mode Abel Vesa
2023-11-01 21:28 ` Dmitry Baryshkov
2023-11-10 8:32 ` Jagadeesh Kona
2023-11-01 9:04 ` [PATCH RESEND v3 4/5] clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode Abel Vesa
2023-11-01 21:31 ` Dmitry Baryshkov
2023-11-03 20:15 ` Bjorn Andersson
2023-11-10 8:32 ` Jagadeesh Kona
2023-11-22 12:50 ` Vikash Garodia
2023-11-07 13:05 ` Bryan O'Donoghue
2023-11-07 21:21 ` Konrad Dybcio [this message]
2023-11-08 1:15 ` Bryan O'Donoghue
2023-11-10 8:29 ` Jagadeesh Kona
2023-11-10 11:09 ` Bryan O'Donoghue
2023-11-01 9:04 ` [PATCH RESEND v3 5/5] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode Abel Vesa
2023-11-03 10:44 ` Bryan O'Donoghue
2023-11-04 12:00 ` Konrad Dybcio
2023-11-01 11:07 ` [PATCH RESEND v3 0/5] PM: domains: Add control for switching back and forth to HW control Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82a25b12-7a63-4c75-8a46-624bc35c6752@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=quic_jkona@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
--cc=tdas@qti.qualcomm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.