Re: [PATCH v11 11/13] x86: make Xen early boot code relocatable

From: Doug Goldstein <cardoe@cardoe.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: jgross@suse.com, sstabellini@kernel.org,
	andrew.cooper3@citrix.com, pgnet.dev@gmail.com,
	ning.sun@intel.com, julien.grall@arm.com, jbeulich@suse.com,
	xen-devel@lists.xenproject.org, qiaowei.ren@intel.com,
	gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v11 11/13] x86: make Xen early boot code relocatable
Date: Wed, 11 Jan 2017 14:23:38 -0600	[thread overview]
Message-ID: <82a5710e-d4aa-d2d2-e8a2-362d730a6d9e@cardoe.com> (raw)
In-Reply-To: <20170111200505.GA32675@olila.local.net-space.pl>

[-- Attachment #1.1.1: Type: text/plain, Size: 3097 bytes --]

On 1/11/17 2:05 PM, Daniel Kiper wrote:
> On Mon, Jan 09, 2017 at 08:05:01PM -0600, Doug Goldstein wrote:
>> On 12/5/16 4:25 PM, Daniel Kiper wrote:
> 
> [...]
> 
>>>          /* Save trampoline address for later use. */
>>>          shl     $4, %ecx
>>> -        mov     %ecx,sym_phys(trampoline_phys)
>>> +        mov     %ecx,sym_fs(trampoline_phys)
>>> +
>>> +        /* Save Xen image load base address for later use. */
>>> +        mov     %esi,sym_fs(xen_phys_start)
>>> +        mov     %esi,sym_fs(trampoline_xen_phys_start)
>>> +
>>> +        /* Setup stack. %ss was initialized earlier. */
>>> +        lea     1024+sym_esi(cpu0_stack),%esp
>>
>> Not sure if this is the bad code or what but after this patch in the
>> series the stack is at 0xAD000 which is in the middle of VGA memory so
>> the stack is getting screwy (hence my email last week). And the stack is
>> bad in trampoline_setup, before trampoline_setup the stack seems fine.
>>
>> This is from my hacked up version of iPXE...
>>
>> Type / Addr / Number of Pages / Flags
>>
>> Conventional: 0x000059000 :      69 : f
>> Reserved:     0x00009e000 :       2 : f
>> Conventional: 0x000100000 :   65280 : f
>>
>> As you can see from 0xA0000 to 0x100000 isn't mentioned but everything I
>> can find on EFI says if the range isn't mentioned you shouldn't use it.
> 
> Could you provide full EFI memory map from this machine?
> 
> Daniel
> 

Its a NUC5i5MYHE with 16gb of RAM. Let me know if you need help
deciphering this. I'm going to convert this output into the same as
Linux's output when I get some time.

Name        : Start Addr : Pages : Flags
Conventional: 0x000000000 :      88 : f
Reserved:     0x000058000 :       1 : f
Conventional: 0x000059000 :      69 : f
Reserved:     0x00009e000 :       2 : f
Conventional: 0x000100000 :   65280 : f
BS Code:      0x010000000 :      11 : f
Conventional: 0x01000b000 :  547960 : f
BS Data:      0x095c83000 :      64 : f
Conventional: 0x095cc3000 :   30743 : f
Loader Code:  0x09d4da000 :     180 : f
BS Data:      0x09d58e000 :     484 : f
RS Data:      0x09d772000 :    1273 : 800000000000000f
BS Data:      0x09dc6b000 :       8 : f
Conventional: 0x09dc73000 :    2260 : f
BS Data:      0x09e547000 :   13272 : f
Conventional: 0x0a191f000 :     481 : f
BS Code:      0x0a1b00000 :    1925 : f
Reserved:     0x0a2285000 :     187 : f
ACPI Reclaim: 0x0a2340000 :      37 : f
ACPI NVS:     0x0a2365000 :    2352 : f
RS Data:      0x0a2c95000 :     781 : 800000000000000f
RS Code:      0x0a2fa2000 :      93 : 800000000000000f
BS Data:      0x0a2fff000 :       1 : f
Conventional: 0x100000000 : 3497984 : f
Reserved:     0x0a3800000 :   18432 : 0
MMAP IO:      0x0f8000000 :   16384 : 8000000000000001
MMAP IO:      0x0fec00000 :       1 : 8000000000000001
MMAP IO:      0x0fed00000 :       4 : 8000000000000001
MMAP IO:      0x0fed1c000 :       4 : 8000000000000001
MMAP IO:      0x0fee00000 :       1 : 8000000000000001
MMAP IO:      0x0ff000000 :    4096 : 8000000000000001

-- 
Doug Goldstein

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel