From: Bastian Krause <bst@pengutronix.de>
To: linux-nfs@vger.kernel.org
Cc: Steve Dickson <steved@redhat.com>, kernel@pengutronix.de
Subject: Re: [PATCH rpcbind] autotools/systemd: call rpcbind with -w only on enabled warm starts
Date: Wed, 6 Jul 2022 12:11:04 +0200 [thread overview]
Message-ID: <82f7edc0-c9d4-6a9a-1360-1b6e5b2f1d59@pengutronix.de> (raw)
In-Reply-To: <20210611122803.24747-1-bst@pengutronix.de>
On 6/11/21 14:28, Bastian Krause wrote:
> If rpcbind is configured with --disable-warmstarts it responds on -w
> with its usage string. This is not helpful in a systemd service, so pass
> -w conditionally.
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
Gentle ping!
Regards,
Bastian
> ---
> configure.ac | 6 ++++++
> systemd/rpcbind.service.in | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index c0ef896..c2069a2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -20,6 +20,12 @@ AM_CONDITIONAL(LIBSETDEBUG, test x$lib_setdebug = xyes)
> AC_ARG_ENABLE([warmstarts],
> AS_HELP_STRING([--enable-warmstarts], [Enables Warm Starts @<:@default=no@:>@]))
> AM_CONDITIONAL(WARMSTART, test x$enable_warmstarts = xyes)
> +AS_IF([test x$enable_warmstarts = xyes], [
> + warmstarts_opt=-w
> +], [
> + warmstarts_opt=
> +])
> +AC_SUBST([warmstarts_opt], [$warmstarts_opt])
>
> AC_ARG_ENABLE([rmtcalls],
> AS_HELP_STRING([--enable-rmtcalls], [Enables Remote Calls @<:@default=no@:>@]))
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index 7b1c74b..c892ca8 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -12,7 +12,7 @@ Wants=rpcbind.target
> [Service]
> Type=notify
> # distro can provide a drop-in adding EnvironmentFile=-/??? if needed.
> -ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS -w -f
> +ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS @warmstarts_opt@ -f
>
> [Install]
> WantedBy=multi-user.target
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-07-06 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 12:28 [PATCH rpcbind] autotools/systemd: call rpcbind with -w only on enabled warm starts Bastian Krause
2022-07-06 10:11 ` Bastian Krause [this message]
2022-07-12 20:39 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f7edc0-c9d4-6a9a-1360-1b6e5b2f1d59@pengutronix.de \
--to=bst@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.