All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Andrii Nakryiko <andriin@fb.com>, <bpf@vger.kernel.org>,
	<netdev@vger.kernel.org>, <ast@fb.com>, <daniel@iogearbox.net>
Cc: <andrii.nakryiko@gmail.com>, <kernel-team@fb.com>
Subject: Re: [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array map
Date: Tue, 12 May 2020 20:19:57 -0700	[thread overview]
Message-ID: <832dc9d7-2a38-9728-a845-2f7f7e34bb74@fb.com> (raw)
In-Reply-To: <20200512235925.3817805-1-andriin@fb.com>



On 5/12/20 4:59 PM, Andrii Nakryiko wrote:
> mmap() subsystem allows user-space application to memory-map region with
> initial page offset. This wasn't taken into account in initial implementation
> of BPF array memory-mapping. This would result in wrong pages, not taking into
> account requested page shift, being memory-mmaped into user-space. This patch
> fixes this gap and adds a test for such scenario.
> 
> Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2020-05-13  3:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 23:59 [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array map Andrii Nakryiko
2020-05-13  3:19 ` Yonghong Song [this message]
2020-05-14 19:42   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=832dc9d7-2a38-9728-a845-2f7f7e34bb74@fb.com \
    --to=yhs@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.