From: Waiman Long <longman@redhat.com>
To: Liu Shixin <liushixin2@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zefan Li <lizefan.x@bytedance.com>,
Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v2 0/9] mm: Use hotplug_memory_notifier() instead of register_hotmemory_notifier()
Date: Tue, 20 Sep 2022 10:22:15 -0400 [thread overview]
Message-ID: <835004ff-3bae-7b08-b072-7e971891ba1f@redhat.com> (raw)
In-Reply-To: <20220920025123.2868953-1-liushixin2@huawei.com>
On 9/19/22 22:51, Liu Shixin wrote:
> Patch f02c69680088 introduced register_hotmemory_notifier() to avoid a
> compile problem with gcc-4.4.4:
>
> When CONFIG_MEMORY_HOTPLUG=n, we don't want the memory-hotplug notifier
> handlers to be included in the .o files, for space reasons.
>
> The existing hotplug_memory_notifier() tries to handle this but testing
> with gcc-4.4.4 shows that it doesn't work - the hotplug functions are
> still present in the .o files.
>
> Since patch 316346243be6 has already updated the minimum gcc version to 5.1.
> The previous problem mentioned in patch f02c69680088 is not existed. So we
> can now revert to use hotplug_memory_notifier() directly rather than
> register_hotmemory_notifier().
>
> Patch [1-6] replace register_hotmemory_notifier() with hotplug_memory_notifier()
> for every caller.
> Patch [7] remove unused register_hotmemory_notifier().
> Patch [8] replace IPC_CALLBACK_PRI with MM_BATCH_CALLBACK_PRI.
> Patch [9] collect all priority of hotplug memory callback into include/linux/memory.h
> for easy reading.
>
> v1->v2: fix compile error of patch [4,5].
I agreed with David's comments about patch 8 and 9. My understanding is
that this patch series makes it easy to see all the priorities of the
various memory hotplug notifier callbacks and hence their calling order.
It is kind of being stated when mentioning about patch 9 above. However,
it should be more prominently mentioned as the first thing that I look
for is the benefit provided by this patch series.
Cheers,
Longman
next prev parent reply other threads:[~2022-09-20 14:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 2:51 [PATCH v2 0/9] mm: Use hotplug_memory_notifier() instead of register_hotmemory_notifier() Liu Shixin
2022-09-20 2:51 ` [PATCH v2 1/9] cgroup/cpuset: use hotplug_memory_notifier() directly Liu Shixin
2022-09-20 11:59 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 2/9] fs/proc/kcore.c: " Liu Shixin
2022-09-20 11:59 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 3/9] mm/slub.c: " Liu Shixin
2022-09-20 12:00 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 4/9] mm/mmap: " Liu Shixin
2022-09-20 12:02 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 5/9] mm/mm_init.c: " Liu Shixin
2022-09-20 12:03 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 6/9] ACPI: HMAT: " Liu Shixin
2022-09-20 12:04 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 7/9] memory: remove unused register_hotmemory_notifier() Liu Shixin
2022-09-20 12:06 ` David Hildenbrand
2022-09-22 12:54 ` Liu Shixin
2022-09-22 13:07 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 8/9] memory: replace IPC_CALLBACK_PRI with MM_BATCH_CALLBACK_PRI Liu Shixin
2022-09-20 12:07 ` David Hildenbrand
2022-09-22 13:12 ` Liu Shixin
2022-09-20 2:51 ` [PATCH v2 9/9] memory: clean up hotplug memory callback priority Liu Shixin
2022-09-20 12:08 ` David Hildenbrand
2022-09-20 14:22 ` Waiman Long [this message]
2022-09-22 13:33 ` [PATCH v2 0/9] mm: Use hotplug_memory_notifier() instead of register_hotmemory_notifier() Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835004ff-3bae-7b08-b072-7e971891ba1f@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=lizefan.x@bytedance.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.