From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Anchal Agarwal <anchalag@amazon.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, jgross@suse.com,
linux-pm@vger.kernel.org, linux-mm@kvack.org, kamatam@amazon.com,
sstabellini@kernel.org, konrad.wilk@oracle.com,
roger.pau@citrix.com, axboe@kernel.dk, davem@davemloft.net,
rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
peterz@infradead.org, eduval@amazon.com, sblbir@amazon.com,
xen-devel@lists.xenproject.org, vkuznets@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dwmw@amazon.co.uk, benh@kernel.crashing.org
Subject: Re: [PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support
Date: Sat, 30 May 2020 18:56:30 -0400 [thread overview]
Message-ID: <835ca864-3e35-9a82-f3fd-24ca4e2ec06e@oracle.com> (raw)
In-Reply-To: <7fd12227f923eacc5841b47bd69f72b4105843a7.1589926004.git.anchalag@amazon.com>
On 5/19/20 7:25 PM, Anchal Agarwal wrote:
>
> int xenbus_dev_resume(struct device *dev)
> {
> - int err;
> + int err = 0;
That's not necessary.
> struct xenbus_driver *drv;
> struct xenbus_device *xdev
> = container_of(dev, struct xenbus_device, dev);
> -
> + bool xen_suspend = xen_suspend_mode_is_xen_suspend();
> DPRINTK("%s", xdev->nodename);
>
> if (dev->driver == NULL)
> @@ -627,24 +645,32 @@ int xenbus_dev_resume(struct device *dev)
> drv = to_xenbus_driver(dev->driver);
> err = talk_to_otherend(xdev);
> if (err) {
> - pr_warn("resume (talk_to_otherend) %s failed: %i\n",
> + pr_warn("%s (talk_to_otherend) %s failed: %i\n",
Please use dev_warn() everywhere, we just had a bunch of patches that
replaced pr_warn(). In fact, this is one of the lines that got changed.
>
> int xenbus_dev_cancel(struct device *dev)
> {
> - /* Do nothing */
> - DPRINTK("cancel");
> + int err = 0;
Again, no need to initialize.
> + struct xenbus_driver *drv;
> + struct xenbus_device *xdev
> + = container_of(dev, struct xenbus_device, dev);
xendev please to be consistent with other code. And use to_xenbus_device().
-boris
next prev parent reply other threads:[~2020-05-30 22:57 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 23:24 [PATCH 00/12] Fix PM hibernation in Xen guests Anchal Agarwal
2020-05-19 23:24 ` Anchal Agarwal
2020-05-19 23:24 ` [PATCH 01/12] xen/manage: keep track of the on-going suspend mode Anchal Agarwal
2020-05-19 23:24 ` Anchal Agarwal
2020-05-30 22:26 ` Boris Ostrovsky
2020-06-01 21:00 ` Agarwal, Anchal
2020-06-01 22:39 ` Boris Ostrovsky
2020-05-19 23:25 ` [PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support Anchal Agarwal
2020-05-19 23:25 ` Anchal Agarwal
2020-05-30 22:56 ` Boris Ostrovsky [this message]
2020-06-01 23:36 ` Agarwal, Anchal
2020-05-19 23:25 ` [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume Anchal Agarwal
2020-05-19 23:25 ` Anchal Agarwal
2020-05-30 23:02 ` Boris Ostrovsky
2020-06-04 23:03 ` Anchal Agarwal
2020-06-04 23:03 ` Anchal Agarwal
2020-06-05 21:39 ` Boris Ostrovsky
2020-06-05 21:39 ` Boris Ostrovsky
2020-06-08 16:52 ` Anchal Agarwal
2020-06-08 16:52 ` Anchal Agarwal
2020-06-08 18:49 ` Boris Ostrovsky
2020-06-08 18:49 ` Boris Ostrovsky
2020-05-19 23:26 ` [PATCH 04/12] x86/xen: add system core suspend and resume callbacks Anchal Agarwal
2020-05-19 23:26 ` Anchal Agarwal
2020-05-30 23:10 ` Boris Ostrovsky
2020-06-03 22:40 ` Agarwal, Anchal
2020-06-05 21:24 ` Boris Ostrovsky
2020-06-08 17:09 ` Anchal Agarwal
2020-06-08 17:09 ` Anchal Agarwal
2020-05-19 23:26 ` [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation Anchal Agarwal
2020-05-19 23:34 ` Anchal Agarwal
2020-05-19 23:34 ` Anchal Agarwal
2020-05-19 23:26 ` Anchal Agarwal
2020-05-19 23:29 ` Singh, Balbir
2020-05-19 23:29 ` Singh, Balbir
2020-05-19 23:36 ` Agarwal, Anchal
2020-05-19 23:36 ` Agarwal, Anchal
2020-05-30 23:17 ` Boris Ostrovsky
2020-06-01 20:46 ` Agarwal, Anchal
2020-05-19 23:27 ` [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation Anchal Agarwal
2020-05-19 23:27 ` Anchal Agarwal
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:07 ` kbuild test robot
2020-05-20 5:07 ` kbuild test robot
2020-05-21 23:48 ` Anchal Agarwal
2020-05-21 23:48 ` Anchal Agarwal
2020-05-22 1:43 ` Singh, Balbir
2020-05-22 1:43 ` Singh, Balbir
2020-05-23 12:32 ` kbuild test robot
2020-05-23 12:32 ` kbuild test robot
2020-05-28 12:30 ` Roger Pau Monné
2020-05-28 12:30 ` Roger Pau Monné
2020-05-19 23:28 ` [PATCH 07/12] xen-netfront: " Anchal Agarwal
2020-05-19 23:28 ` Anchal Agarwal
2020-05-19 23:28 ` [PATCH 08/12] xen/time: introduce xen_{save,restore}_steal_clock Anchal Agarwal
2020-05-19 23:28 ` Anchal Agarwal
2020-05-30 23:32 ` Boris Ostrovsky
2020-05-19 23:28 ` [PATCH 09/12] x86/xen: save and restore steal clock Anchal Agarwal
2020-05-19 23:28 ` Anchal Agarwal
2020-05-30 23:44 ` Boris Ostrovsky
2020-06-04 18:33 ` Anchal Agarwal
2020-06-04 18:33 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 10/12] xen: Introduce wrapper for save/restore sched clock offset Anchal Agarwal
2020-05-19 23:29 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 11/12] xen: Update sched clock offset to avoid system instability in hibernation Anchal Agarwal
2020-05-19 23:29 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA Anchal Agarwal
2020-05-19 23:29 ` Anchal Agarwal
2020-05-28 17:59 ` [PATCH 00/12] Fix PM hibernation in Xen guests Agarwal, Anchal
2020-05-28 17:59 ` Agarwal, Anchal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835ca864-3e35-9a82-f3fd-24ca4e2ec06e@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=anchalag@amazon.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=eduval@amazon.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=roger.pau@citrix.com \
--cc=sblbir@amazon.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.