From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, John Garry <john.garry@huawei.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 7/8] blk-mq: add blk_mq_all_tag_iter
Date: Wed, 27 May 2020 20:21:46 +0200 [thread overview]
Message-ID: <8374b3ea-560a-117b-421e-a2f84401bbdb@suse.de> (raw)
In-Reply-To: <20200527180644.514302-8-hch@lst.de>
On 5/27/20 8:06 PM, Christoph Hellwig wrote:
> From: Ming Lei <ming.lei@redhat.com>
>
> Add a new blk_mq_all_tag_iter function to iterate over all allocated
> scheduler tags and driver tags. This is more flexible than the existing
> blk_mq_all_tag_busy_iter function as it allows the callers to do whatever
> they want on allocated request instead of being limited to started
> requests.
>
> It will be used to implement draining allocated requests on specified
> hctx in this patchset.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> [hch: switch from the two booleans to a more readable flags field and
> consolidate the tags iter functions]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-mq-tag.c | 46 +++++++++++++++++++++++++++++-----------------
> block/blk-mq-tag.h | 2 ++
> 2 files changed, 31 insertions(+), 17 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-05-27 18:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 18:06 blk-mq: improvement CPU hotplug (simplified version) v4 Christoph Hellwig
2020-05-27 18:06 ` [PATCH 1/8] blk-mq: remove the bio argument to ->prepare_request Christoph Hellwig
2020-05-27 18:16 ` Johannes Thumshirn
2020-05-27 18:06 ` [PATCH 2/8] blk-mq: simplify the blk_mq_get_request calling convention Christoph Hellwig
2020-05-27 18:17 ` Johannes Thumshirn
2020-05-27 18:06 ` [PATCH 3/8] blk-mq: move more request initialization to blk_mq_rq_ctx_init Christoph Hellwig
2020-05-27 18:16 ` Hannes Reinecke
2020-05-28 9:50 ` Johannes Thumshirn
2020-05-27 18:06 ` [PATCH 4/8] blk-mq: rename BLK_MQ_TAG_FAIL to BLK_MQ_NO_TAG Christoph Hellwig
2020-05-27 18:14 ` Johannes Thumshirn
2020-05-27 18:17 ` Hannes Reinecke
2020-05-27 22:38 ` Bart Van Assche
2020-05-27 18:06 ` [PATCH 5/8] blk-mq: use BLK_MQ_NO_TAG in more places Christoph Hellwig
2020-05-27 18:15 ` Johannes Thumshirn
2020-05-27 18:18 ` Hannes Reinecke
2020-05-27 22:38 ` Bart Van Assche
2020-05-27 18:06 ` [PATCH 6/8] blk-mq: open code __blk_mq_alloc_request in blk_mq_alloc_request_hctx Christoph Hellwig
2020-05-27 18:06 ` [PATCH 7/8] blk-mq: add blk_mq_all_tag_iter Christoph Hellwig
2020-05-27 18:21 ` Hannes Reinecke [this message]
2020-05-27 22:52 ` Bart Van Assche
2020-05-27 18:06 ` [PATCH 8/8] blk-mq: drain I/O when all CPUs in a hctx are offline Christoph Hellwig
2020-05-27 18:26 ` Hannes Reinecke
2020-05-27 23:09 ` Bart Van Assche
2020-05-28 1:46 ` Ming Lei
2020-05-28 3:33 ` Bart Van Assche
2020-05-28 5:19 ` Ming Lei
2020-05-28 13:37 ` Bart Van Assche
2020-05-28 17:21 ` Paul E. McKenney
2020-05-29 1:53 ` Ming Lei
2020-05-29 3:07 ` Paul E. McKenney
2020-05-29 3:53 ` Ming Lei
2020-05-29 18:13 ` Paul E. McKenney
2020-05-29 19:55 ` Bart Van Assche
2020-05-29 21:12 ` Paul E. McKenney
2020-05-29 1:13 ` Ming Lei
2020-05-27 20:07 ` blk-mq: improvement CPU hotplug (simplified version) v4 Bart Van Assche
2020-05-27 20:31 ` John Garry
2020-05-29 13:26 ` Christoph Hellwig
2020-05-28 8:29 ` John Garry
2020-05-29 13:53 Christoph Hellwig
2020-05-29 13:53 ` [PATCH 7/8] blk-mq: add blk_mq_all_tag_iter Christoph Hellwig
2020-05-29 16:14 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8374b3ea-560a-117b-421e-a2f84401bbdb@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.