From: Niels Dossche <dossche.niels@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
noltari@gmail.com
Subject: Re: [PATCH] net: mdio: Fix ENOMEM return value in BCM6368 mux bus controller
Date: Fri, 29 Apr 2022 01:07:36 +0200 [thread overview]
Message-ID: <84d36568-266a-15e9-1597-790a18389b51@gmail.com> (raw)
In-Reply-To: <YmsbipglEOK/ODW7@lunn.ch>
On 29/04/2022 00:56, Andrew Lunn wrote:
> On Thu, Apr 28, 2022 at 11:19:32PM +0200, Niels Dossche wrote:
>> Error values inside the probe function must be < 0. The ENOMEM return
>> value has the wrong sign: it is positive instead of negative.
>> Add a minus sign.
>>
>> Fixes: e239756717b5 ("net: mdio: Add BCM6368 MDIO mux bus controller")
>> Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Hi Niels
>
> If you find any more issues like this in the network stack and its
> drivers, please take a read of
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Hi Andrew
Thanks for the review.
My apologies, I will make sure to correctly tag the tree in the subject in the future.
Kind regards
Niels
>
> Andrew
next prev parent reply other threads:[~2022-04-28 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 21:19 [PATCH] net: mdio: Fix ENOMEM return value in BCM6368 mux bus controller Niels Dossche
2022-04-28 22:56 ` Andrew Lunn
2022-04-28 23:07 ` Niels Dossche [this message]
2022-04-29 16:04 ` Florian Fainelli
2022-04-30 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d36568-266a-15e9-1597-790a18389b51@gmail.com \
--to=dossche.niels@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.