Re: [PATCH 4/4] scsi: core: only put parent device if host state isn't in SHOST_CREATED

From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Cc: John Garry <john.garry@huawei.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 4/4] scsi: core: only put parent device if host state isn't in SHOST_CREATED
Date: Wed, 2 Jun 2021 20:08:35 -0700	[thread overview]
Message-ID: <851db5c8-b4c4-790b-0877-eeea9737f2f3@acm.org> (raw)
In-Reply-To: <20210602133029.2864069-5-ming.lei@redhat.com>

On 6/2/21 6:30 AM, Ming Lei wrote:
> get_device(shost->shost_gendev.parent) is called after host state is
> changed to SHOST_RUNNING. So scsi_host_dev_release() shouldn't release
> the parent device if host state is still SHOST_CREATED.
> 
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
>  drivers/scsi/hosts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index 7049844adb6b..34db5be7a562 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -350,7 +350,7 @@ static void scsi_host_dev_release(struct device *dev)
>  
>  	ida_simple_remove(&host_index_ida, shost->host_no);
>  
> -	if (parent)
> +	if (shost->shost_state != SHOST_CREATED)
>  		put_device(parent);
>  	kfree(shost);
>  }

Not sure what others think but I prefer that this patch would also be
merged into patch 2/4.

Thanks,

Bart.