Re: [PATCH wpan-next v2 04/11] mac802154: Handle associating

From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Alexander Aring <alex.aring@gmail.com>,
	linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH wpan-next v2 04/11] mac802154: Handle associating
Date: Sat, 16 Sep 2023 17:36:25 +0200	[thread overview]
Message-ID: <85942db2-2dbe-ae64-49d9-c2f0fd53e31e@datenfreihafen.org> (raw)
In-Reply-To: <20230901170501.1066321-5-miquel.raynal@bootlin.com>

Hello Miquel.

On 01.09.23 19:04, Miquel Raynal wrote:
> Joining a PAN officially goes by associating with a coordinator. This
> coordinator may have been discovered thanks to the beacons it sent in
> the past. Add support to the MAC layer for these associations, which
> require:
> - Sending an association request
> - Receiving an association response
> 
> The association response contains the association status, eventually a
> reason if the association was unsuccessful, and finally a short address
> that we should use for intra-PAN communication from now on, if we
> required one (which is the default, and not yet configurable).
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>   include/net/cfg802154.h         |   1 +
>   include/net/ieee802154_netdev.h |   5 ++
>   net/ieee802154/core.c           |  14 ++++
>   net/mac802154/cfg.c             |  70 ++++++++++++++++++
>   net/mac802154/ieee802154_i.h    |  19 +++++
>   net/mac802154/main.c            |   2 +
>   net/mac802154/rx.c              |   9 +++
>   net/mac802154/scan.c            | 127 ++++++++++++++++++++++++++++++++
>   8 files changed, 247 insertions(+)
> 
> diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> index 1c22cef77425..df1f6c905c2d 100644
> --- a/include/net/cfg802154.h
> +++ b/include/net/cfg802154.h
> @@ -503,6 +503,7 @@ struct wpan_dev {
>   	struct mutex association_lock;
>   	struct ieee802154_pan_device *parent;
>   	struct list_head children;
> +	unsigned int association_generation;

Could you explain what you are suing this for? I see it icreases in 
free_peer_structure as weel as in associate. But I am not clear what 
this is used for.

regards
Stefan Schmidt