From: Mario Kicherer <dev@kicherer.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-spi@vger.kernel.org, han.xu@nxp.com, broonie@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: dt-bindings: spi-fsl-qspi: add optional sampling-delay
Date: Tue, 17 Jan 2023 17:33:16 +0100 [thread overview]
Message-ID: <85967a3fbce7051449f8d2b29ce5a47c@kicherer.org> (raw)
In-Reply-To: <20230117141057.GA2991740-robh@kernel.org>
Hello,
unfortunately, the rx-sample-delay-ns property does not fit here, as we
can only delay
the sampling point between zero and three "half cycles" (or edges), not
by an arbitrary
number of nanoseconds.
Regarding the bot message, I do not understand what is wrong in my
patch. I found similar
property descriptions in other files and also in the official doc [1]
there is an equal
(to me) example under "clock-frequency", if I am not missing something.
Thank you for the review!
Best regards,
Mario
[1] https://docs.kernel.org/devicetree/bindings/writing-schema.html
On 2023-01-17 15:10, Rob Herring wrote:
> On Mon, Jan 16, 2023 at 12:50:49PM +0100, Mario Kicherer wrote:
>> Add optional sampling-delay property to delay the internal sampling
>> point for
>> incoming data.
>>
>> Signed-off-by: Mario Kicherer <dev@kicherer.org>
>> ---
>> Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml | 6
>> ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
>> b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
>> index e58644558412..7952a4be938b 100644
>> --- a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
>> @@ -54,6 +54,12 @@ properties:
>> - const: qspi_en
>> - const: qspi
>>
>> + fsl,qspi-sampling-delay:
>> + description: delay sampling of incoming data by this number of
>> half cycles
>
> Use the common rx-sample-delay-ns property.
>
>> + minimum: 0
>> + maximum: 3
>> + default: 0
>> +
>> required:
>> - compatible
>> - reg
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2023-01-17 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 11:50 [PATCH 0/2] spi: spi-fsl-qspi: support setting sampling delay through devicetree Mario Kicherer
2023-01-16 11:50 ` [PATCH 1/2] spi: dt-bindings: spi-fsl-qspi: add optional sampling-delay Mario Kicherer
2023-01-16 16:36 ` Rob Herring
2023-01-17 14:10 ` Rob Herring
2023-01-17 16:33 ` Mario Kicherer [this message]
2023-01-17 17:10 ` Krzysztof Kozlowski
2023-01-17 21:05 ` han.xu
2023-01-18 8:01 ` Michael Walle
2023-01-18 8:03 ` Krzysztof Kozlowski
2023-01-18 8:51 ` Michael Walle
2023-01-18 14:58 ` Mario Kicherer
2023-01-16 11:50 ` [PATCH 2/2] spi: spi-fsl-qspi: support setting sampling delay through devicetree Mario Kicherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85967a3fbce7051449f8d2b29ce5a47c@kicherer.org \
--to=dev@kicherer.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=han.xu@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.