From: Marcel Holtmann <marcel@holtmann.org>
To: Harry Morris <h.morris@cascoda.com>
Cc: Alexander Aring <aar@pengutronix.de>,
Harry Morris <harrymorris12@gmail.com>,
linux-wpan@vger.kernel.org,
Stefan Schmidt <stefan@osg.samsung.com>
Subject: Re: [PATCH v7 1/3] ieee802154: Add CA8210 IEEE 802.15.4 device driver
Date: Tue, 17 Jan 2017 11:08:11 +0100 [thread overview]
Message-ID: <85E4F697-F359-4E05-AF3A-D74560DB2049@holtmann.org> (raw)
In-Reply-To: <02d9d99c-5cb7-2bfe-6140-5eef3d93ccc6@cascoda.com>
Hi Harry,
>>> <snip>
>>> +
>>> + if (ca8210_spi_transfer(
>>> + device_ref, &command.command_id, command.length + 2)
>>> + )
>> code style here? Did you run checkpatch?
> checkpatch didn't throw up any complaints regarding style - from what I can see the kernel guidelines are fairly flexible when it comes to splitting long lines. I'm totally happy to newline each argument or something though eg.
>
> if (ca8210_spi_transfer(
> device_ref,
> &command.command_id
> command.length + 2)
> )
actually checkpatch --strict is what you should be using.
ca810_spi_transfer(device_ref, &command.command_id,
command.length + 2)
Use tabs as much as possible and fill up the rest with spaces to that parameters align. Multiple parameters in the same line is fine. Fill them up as much as possible.
Regards
Marcel
next prev parent reply other threads:[~2017-01-17 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 15:41 [PATCH v7 0/3] ieee802154: Add support for Cascoda CA8210 Harry Morris
2017-01-10 15:41 ` [PATCH v7 1/3] ieee802154: Add CA8210 IEEE 802.15.4 device driver Harry Morris
2017-01-13 12:59 ` Stefan Schmidt
[not found] ` <84e02f0a-9b85-888e-be2a-d9d72fd7b7a0@pengutronix.de>
2017-01-16 11:47 ` Harry Morris
2017-01-17 10:08 ` Marcel Holtmann [this message]
2017-01-18 9:27 ` Alexander Aring
2017-01-10 15:41 ` [PATCH v7 2/3] ieee802154: Add device tree documentation for CA8210 Harry Morris
[not found] ` <20170110154122.6724-3-h.morris-viW/wkEPc65BDgjK7y7TUQ@public.gmane.org>
2017-01-13 12:47 ` Stefan Schmidt
2017-01-13 12:47 ` Stefan Schmidt
2017-01-10 15:41 ` [PATCH v7 3/3] ieee802154: Add entry in MAINTAINTERS for CA8210 driver Harry Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85E4F697-F359-4E05-AF3A-D74560DB2049@holtmann.org \
--to=marcel@holtmann.org \
--cc=aar@pengutronix.de \
--cc=h.morris@cascoda.com \
--cc=harrymorris12@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=stefan@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.