All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Blechmann <tim@klingt.org>
To: "Arnaud POULIQUEN" <arnaud.pouliquen@foss.st.com>,
	"Agostiño Carballeira"
	<agostino.carballeira@native-instruments.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Tim Blechmann <tim.blechmann@gmail.com>,
	linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus - prevent possible race condition
Date: Sat, 16 Sep 2023 09:38:20 +0800	[thread overview]
Message-ID: <862d369b-4f6d-f64c-ffa3-fb7740df42cb@klingt.org> (raw)
In-Reply-To: <12d59a09-bb83-26e7-321e-1407b3f814e8@foss.st.com>

>> Interestingly, when we replace rpmsg_send by rpmsg_trysend + busywait loop, this
>> mutual stall doesn't happen at all.
> 
> What do you mean by busywait? Do you add a delay between 2 rpmsg_trysend()
> calls? If yes, you probably add delay that avoid the issue.
> 
> That said rpmsg_trysend is recommended for baremetal to avoid to block the system.

to avoid misunderstanding here: replacing `rpmsg_send` by a 
`rpmsg_trysend` / `usleep` loop on the *linux* side works around the 
issue (i.e. in our own small module and in rpmsg_char).

thanks,
tim

  reply	other threads:[~2023-09-16  1:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  8:36 [PATCH 1/1] rpmsg: virtio_rpmsg_bus - prevent possible race condition Tim Blechmann
2023-09-04 13:52 ` Arnaud POULIQUEN
2023-09-04 20:43   ` Mathieu Poirier
2023-09-05  1:33     ` Tim Blechmann
2023-09-05 16:02       ` Mathieu Poirier
2023-09-08 15:04       ` Arnaud POULIQUEN
2023-09-09  6:28         ` Tim Blechmann
2023-09-11 17:20           ` Arnaud POULIQUEN
2023-09-13  1:07             ` Tim Blechmann
2023-09-13  1:11               ` Tim Blechmann
2023-09-13  7:44                 ` Arnaud POULIQUEN
2023-09-13  8:47                   ` Tim Blechmann
2023-09-13 10:02                     ` Arnaud POULIQUEN
     [not found]                     ` <CAG2LOc42AG5H56=tzz8_2WrrBiy9d74qYmgPQaEVGrzWTNqodg@mail.gmail.com>
2023-09-14 17:25                       ` Arnaud POULIQUEN
2023-09-16  1:38                         ` Tim Blechmann [this message]
2023-09-13 10:10     ` Arnaud POULIQUEN
2023-09-13 14:46       ` Mathieu Poirier
2023-09-07  4:51 Tim Blechmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=862d369b-4f6d-f64c-ffa3-fb7740df42cb@klingt.org \
    --to=tim@klingt.org \
    --cc=agostino.carballeira@native-instruments.com \
    --cc=arnaud.pouliquen@foss.st.com \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=tim.blechmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.