Re: [PATCH 3/5] s390/uvdevice: Add 'List Secrets' UVC

From: Steffen Eiden <seiden@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Viktor Mihajlovski <mihajlov@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Nico Boehr <nrb@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Hendrik Brueckner <brueckner@linux.ibm.com>
Subject: Re: [PATCH 3/5] s390/uvdevice: Add 'List Secrets' UVC
Date: Wed, 17 May 2023 18:11:05 +0200	[thread overview]
Message-ID: <868405bc-cb04-8bd8-a3db-fb35a2a6beb2@linux.ibm.com> (raw)
In-Reply-To: <20230517180335.05599c6a@p-imbrenda>

Thanks for your review.

On 5/17/23 18:03, Claudio Imbrenda wrote:
>> static int uvio_list_secrets(struct uvio_ioctl_cb *uv_ioctl)
>> +{
>> +	void __user *user_buf_arg = (void __user *)uv_ioctl->argument_addr;
>> +	struct uv_cb_guest_addr uvcb = {
>> +		.header.len = sizeof(uvcb),
>> +		.header.cmd = UVC_CMD_LIST_SECRETS,
>> +	};
>> +	void *secrets = NULL;
>> +	int ret;
>> +
>> +	if (uv_ioctl->argument_len != UVIO_LIST_SECRETS_LEN)
>> +		return -EINVAL;
>> +
>> +	secrets = kvzalloc(uv_ioctl->argument_len, GFP_KERNEL);
>> +	if (!secrets)
>> +		return -ENOMEM;
>> +
>> +	uvcb.addr = (u64)secrets;
> I think you need virt_to_phys()
The UV expects a virtual address here.

> 
>> +	uv_call_sched(0, (u64)&uvcb);
>> +	uv_ioctl->uv_rc = uvcb.header.rc;
>> +	uv_ioctl->uv_rrc = uvcb.header.rrc;
>> +
>> +	if (copy_to_user(user_buf_arg, secrets, uv_ioctl->argument_len))
>> +		ret = -EFAULT;
>> +	else
>> +		ret = 0;
>> +
>> +	kvfree(secrets);
>> +	return ret;
>> +}

Steffen