Re: [PATCH] platform/x86: ideapad-laptop: Add Legion 5 15ARH05 DMI id to set_fn_lock_led_list[]

From: Hans de Goede <hdegoede@redhat.com>
To: Mark Gross <markgross@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,
	Ike Panhc <ike.pan@canonical.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Add Legion 5 15ARH05 DMI id to set_fn_lock_led_list[]
Date: Thu, 12 Jan 2023 17:29:43 +0100	[thread overview]
Message-ID: <86becd6f-71c9-8a68-0332-ce799d20eadb@redhat.com> (raw)
In-Reply-To: <20221215154357.123876-1-hdegoede@redhat.com>

Hi,

On 12/15/22 16:43, Hans de Goede wrote:
> The Lenovo Legion 5 15ARH05 needs ideapad-laptop to call SALS_FNLOCK_ON /
> SALS_FNLOCK_OFF on Fn-lock state change to get the LED in the Fn key to
> correctly reflect the Fn-lock state.
> 
> Add a DMI match for the Legion 5 15ARH05 to the set_fn_lock_led_list[]
> table for this.
> 
> Fixes: 81a5603a0f50 ("platform/x86: ideapad-laptop: Fix interrupt storm on fn-lock toggle on some Yoga laptops")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I've added this to my review-hans (soon to be for-next) branch now.

Regards,

Hans

> ---
>  drivers/platform/x86/ideapad-laptop.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 435d2d3d903b..0eb5bfdd823a 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1621,6 +1621,12 @@ static const struct dmi_system_id set_fn_lock_led_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Legion R7000P2020H"),
>  		}
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Legion 5 15ARH05"),
> +		}
> +	},
>  	{}
>  };
>  