From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Li Qiang" <liq3ea@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Lei Sun" <slei.casper@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods
Date: Thu, 25 Jun 2020 12:21:59 +0200 [thread overview]
Message-ID: <86ed036e-cbf1-834d-59d9-af6db7b750ef@redhat.com> (raw)
In-Reply-To: <nycvar.YSQ.7.77.849.2006251427210.92950@xnncv>
On 6/25/20 11:18 AM, P J P wrote:
> +-- On Thu, 25 Jun 2020, Philippe Mathieu-Daudé wrote --+
> | > @@ -196,7 +196,22 @@ static bool tz_ppc_dummy_accepts(void *opaque, hwaddr addr,
> | > g_assert_not_reached();
> |
> | This is a shame we now have to fill the read/write handlers for
> | unreachable code :(
> |
> | > +static uint64_t tz_ppc_dummy_read(void *opaque, hwaddr addr, unsigned size)
> |
> | I'd instead use a clearer:
> | g_assert_not_reached();
> |
> | > +static void tz_ppc_dummy_write(void *opaque, hwaddr addr,
> |
> | Ditto:
> | g_assert_not_reached();
>
> This will likely be called in tz_ppc_dummy_accepts() above. Do we still want
> to revise this patch? considering read/write callbacks are unreachable.
So a simple comment in each read/write might be sufficient (removing the
qemu_log_mask calls).
next prev parent reply other threads:[~2020-06-25 10:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 18:55 [PATCH v2 0/9] memory: assert and define MemoryRegionOps callbacks P J P
2020-06-24 18:55 ` [PATCH v2 1/9] hw/pci-host: add pci-intack write method P J P
2020-06-29 9:20 ` Li Qiang
2020-06-24 18:55 ` [PATCH v2 2/9] pci-host: add pcie-msi read method P J P
2020-06-29 9:30 ` Li Qiang
2020-06-24 18:55 ` [PATCH v2 3/9] vfio: add quirk device write method P J P
2020-06-29 9:36 ` Li Qiang
2020-06-24 18:55 ` [PATCH v2 4/9] prep: add ppc-parity " P J P
2020-06-25 1:40 ` David Gibson
2020-06-25 6:24 ` Philippe Mathieu-Daudé
2020-06-29 11:22 ` Li Qiang
2020-07-21 8:24 ` Philippe Mathieu-Daudé
2020-06-24 18:55 ` [PATCH v2 5/9] nvram: add nrf51_soc flash read method P J P
2020-06-29 11:17 ` Li Qiang
2020-06-29 11:55 ` P J P
2020-06-29 15:32 ` Paolo Bonzini
2020-06-29 16:05 ` Li Qiang
2020-06-29 15:31 ` Paolo Bonzini
2020-07-16 16:27 ` Peter Maydell
2020-07-21 6:47 ` P J P
2020-07-21 8:33 ` Philippe Mathieu-Daudé
2020-07-21 9:48 ` P J P
2020-06-24 18:55 ` [PATCH v2 6/9] spapr_pci: add spapr msi " P J P
2020-06-25 1:41 ` David Gibson
2020-06-29 9:55 ` Li Qiang
2020-06-24 18:55 ` [PATCH v2 7/9] tz-ppc: add dummy read/write methods P J P
2020-06-25 6:29 ` Philippe Mathieu-Daudé
2020-06-25 9:18 ` P J P
2020-06-25 10:21 ` Philippe Mathieu-Daudé [this message]
2020-06-25 11:24 ` P J P
2020-06-29 15:33 ` Paolo Bonzini
2020-06-25 12:22 ` Peter Maydell
2020-06-29 10:44 ` Li Qiang
2020-06-29 11:48 ` P J P
2020-06-24 18:55 ` [PATCH v2 8/9] imx7-ccm: add digprog mmio write method P J P
2020-06-29 10:47 ` Li Qiang
2020-06-24 18:55 ` [PATCH v2 9/9] memory: assert MemoryRegionOps callbacks are defined P J P
2020-06-29 11:28 ` Li Qiang
2020-06-24 21:35 ` [PATCH v2 0/9] memory: assert and define MemoryRegionOps callbacks no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ed036e-cbf1-834d-59d9-af6db7b750ef@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slei.casper@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.