From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH v2 23/25] ASoC: soc-pcm.c: use helper function
Date: Tue, 24 Jan 2023 02:16:53 +0000 [thread overview]
Message-ID: <871qnku162.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87y1psu1m1.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Current ASoC has many helper function.
This patch use it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
sound/soc/soc-pcm.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 82bb46c7f5cc..8023cc1fe066 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -1012,6 +1012,7 @@ static int __soc_pcm_hw_params(struct snd_soc_pcm_runtime *rtd,
for_each_rtd_codec_dais(rtd, i, codec_dai) {
struct snd_pcm_hw_params codec_params;
+ unsigned int tdm_mask = snd_soc_dai_tdm_mask_get(codec_dai, substream->stream);
/*
* Skip CODECs which don't support the current stream type,
@@ -1034,15 +1035,8 @@ static int __soc_pcm_hw_params(struct snd_soc_pcm_runtime *rtd,
codec_params = *params;
/* fixup params based on TDM slot masks */
- if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK &&
- codec_dai->tx_mask)
- soc_pcm_codec_params_fixup(&codec_params,
- codec_dai->tx_mask);
-
- if (substream->stream == SNDRV_PCM_STREAM_CAPTURE &&
- codec_dai->rx_mask)
- soc_pcm_codec_params_fixup(&codec_params,
- codec_dai->rx_mask);
+ if (tdm_mask)
+ soc_pcm_codec_params_fixup(&codec_params, tdm_mask);
ret = snd_soc_dai_hw_params(codec_dai, substream,
&codec_params);
--
2.25.1
next prev parent reply other threads:[~2023-01-24 2:17 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 2:07 [PATCH v2 00/25] ASoC: use helper function and cleanup Kuninori Morimoto
2023-01-24 2:07 ` [PATCH v2 01/25] ASoC: soc-dai.h: add missing snd_soc_dai_set_widget() Kuninori Morimoto
2023-01-24 2:07 ` [PATCH v2 02/25] ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 03/25] ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 04/25] ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 05/25] ASoC: soc.h: add snd_soc_card_is_instantiated() helper Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 06/25] ASoC: hdmi-codec: use helper function Kuninori Morimoto
2023-01-24 2:09 ` [PATCH v2 07/25] ASoC: hda: " Kuninori Morimoto
2023-01-24 2:09 ` [PATCH v2 08/25] ASoC: max: " Kuninori Morimoto
2023-01-24 2:10 ` [PATCH v2 09/25] ASoC: rt: " Kuninori Morimoto
2023-01-24 4:45 ` kernel test robot
2023-01-24 6:25 ` Kuninori Morimoto
2023-01-30 14:18 ` Mark Brown
2023-01-24 2:10 ` [PATCH v2 10/25] ASoC: cirrus: " Kuninori Morimoto
2023-01-24 2:11 ` [PATCH v2 11/25] ASoC: spear: " Kuninori Morimoto
2023-01-24 2:11 ` [PATCH v2 12/25] ASoC: sdw-mockup: " Kuninori Morimoto
2023-01-24 2:12 ` [PATCH v2 13/25] ASoC: intel: " Kuninori Morimoto
2023-01-24 2:12 ` [PATCH v2 14/25] ASoC: mediatek: " Kuninori Morimoto
2023-01-24 2:12 ` Kuninori Morimoto
2023-01-24 2:12 ` Kuninori Morimoto
2023-01-24 11:03 ` AngeloGioacchino Del Regno
2023-01-24 11:03 ` AngeloGioacchino Del Regno
2023-01-24 11:03 ` AngeloGioacchino Del Regno
2023-01-24 2:13 ` [PATCH v2 15/25] ASoC: meson: " Kuninori Morimoto
2023-01-24 2:13 ` Kuninori Morimoto
2023-01-24 2:13 ` Kuninori Morimoto
2023-01-24 9:29 ` Jerome Brunet
2023-01-24 9:29 ` Jerome Brunet
2023-01-24 9:29 ` Jerome Brunet
2023-01-24 2:13 ` [PATCH v2 16/25] ASoC: rockchip: " Kuninori Morimoto
2023-01-24 2:13 ` Kuninori Morimoto
2023-01-24 2:13 ` Kuninori Morimoto
2023-01-24 2:14 ` [PATCH v2 17/25] ASoC: sof: " Kuninori Morimoto
2023-01-24 2:14 ` [PATCH v2 18/25] ASoC: tegra: " Kuninori Morimoto
2023-01-24 2:14 ` Kuninori Morimoto
2023-01-24 2:15 ` [PATCH v2 19/25] ASoC: ti: " Kuninori Morimoto
2023-01-24 2:15 ` [PATCH v2 20/25] ASoC: soc-core.c: " Kuninori Morimoto
2023-01-24 2:15 ` [PATCH v2 21/25] ASoC: soc-dapm.c: " Kuninori Morimoto
2023-01-24 2:16 ` [PATCH v2 22/25] ASoC: soc-dai.c: " Kuninori Morimoto
2023-01-24 2:16 ` Kuninori Morimoto [this message]
2023-01-24 2:17 ` [PATCH v2 24/25] ASoC: soc-topology.c: " Kuninori Morimoto
2023-01-24 2:17 ` [PATCH v2 25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai Kuninori Morimoto
2023-01-31 22:17 ` [PATCH v2 00/25] ASoC: use helper function and cleanup Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qnku162.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.