Re: [Qemu-devel] [PATCH v9 0/7] trace: Show vCPU info in guest code events

From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: Show vCPU info in guest code events
Date: Tue, 01 Mar 2016 12:10:55 +0100	[thread overview]
Message-ID: <871t7ulagw.fsf@fimbulvetr.bsc.es> (raw)
In-Reply-To: <145641857632.30295.407142116443473458.stgit@localhost> (=?utf-8?Q?=22Llu=C3=ADs?= Vilanova"'s message of "Thu, 25 Feb 2016 17:42:58 +0100")

Lluís Vilanova writes:

> NOTE: This series should complete the framework for guest code tracing. From
>       here on, other series can concurrently add actual events and improve the
>       guest code tracing features and performance (e.g., control tracing
>       independently on each vCPU).

> This series introduces the "vcpu" property for tracing events. This property
> identifies events that are tied to a particular virtual CPU (e.g., executing an
> instruction).

> Events with this property have an implicit vcpu argument, which is shown in the
> trace. In the case of events executed at TCG translation time, two implicit
> arguments are added:

> * The vCPU performing the code translation (shown in the translation-time trace)
> * The vCPU executing the translated code (shown in the execution-time trace)

> Note that the "vcpu" and "tcg" properties are not merged into a single one,
> since events can be defined that relate to a vCPU but are never raised from TCG
> code (e.g., interrupts).

> Changes in v9
> =============

> * Rebase on 774ae42.
> * Fix CPUState typedef, and refactor into a separate patch [Stefan Hajnoczi].
> * Fix TCGv_cpu -> TCGv_env rename in sparc [Stefan Hajnoczi].
[...]

Hi Stefan,

I know it's soft-freeze day, but did you have a chance to take a look at this
series and the other two I sent on top? ("trace: Add events for vCPU memory
accesses" and "trace: Per-vCPU tracing states").

Thanks a lot,
  Lluis