From: Michael Ellerman <mpe@ellerman.id.au>
To: Anton Blanchard <anton@ozlabs.org>,
benh@kernel.crashing.org, paulus@samba.org,
nathanl@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] pseries: Fix 64 bit logical memory block panic
Date: Wed, 15 Jul 2020 22:22:35 +1000 [thread overview]
Message-ID: <87365tufw4.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200715000820.1255764-1-anton@ozlabs.org>
Anton Blanchard <anton@ozlabs.org> writes:
> Booting with a 4GB LMB size causes us to panic:
>
> qemu-system-ppc64: OS terminated: OS panic:
> Memory block size not suitable: 0x0
>
> Fix pseries_memory_block_size() to handle 64 bit LMBs.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Anton Blanchard <anton@ozlabs.org>
> ---
> arch/powerpc/platforms/pseries/hotplug-memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
> index 5ace2f9a277e..6574ac33e887 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-memory.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
> @@ -27,7 +27,7 @@ static bool rtas_hp_event;
> unsigned long pseries_memory_block_size(void)
> {
> struct device_node *np;
> - unsigned int memblock_size = MIN_MEMORY_BLOCK_SIZE;
> + uint64_t memblock_size = MIN_MEMORY_BLOCK_SIZE;
I changed it to u64.
cheers
next prev parent reply other threads:[~2020-07-15 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 0:08 [PATCH] pseries: Fix 64 bit logical memory block panic Anton Blanchard
2020-07-15 12:22 ` Michael Ellerman [this message]
2020-07-15 12:42 ` Aneesh Kumar K.V
2020-07-15 21:00 ` Anton Blanchard
2020-07-16 1:30 ` Paul Mackerras
2020-07-16 14:07 ` Aneesh Kumar K.V
2020-07-16 12:55 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87365tufw4.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=anton@ozlabs.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.