Re: simple-audio-card,mclk-fs

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: simple-audio-card,mclk-fs
Date: 25 Feb 2019 10:48:29 +0900	[thread overview]
Message-ID: <874l8s3azn.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAEnQRZDpJu27_pB=-ZYQjsNPC8eA4-Ur-36niT2hCosMWtC7jw@mail.gmail.com>

Hi Daniel

Thank you for your mail

> Do you have any plans on adding support for multiple mclk-fs values
> in simple-card?
> 
> Usually one constant mclk-fs value is not enough because usually codecs
> have different value depending on rate.
> 
> For example, for wm8524 [1] one can use
> mclk-fs = 256 for rates between 8kHz and 96kHz
> but it needs to change mclk-fs = 128 for 176.4hHz
> and 192kHz.
> 
> I am thinking of something like this:
> 
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -44,6 +44,8 @@
>                 compatible = "simple-audio-card";
>                 simple-audio-card,name = "wm8524-audio";
>                 simple-audio-card,format = "i2s";
> +               simple-audio-card,lrclk-fs = <8000>, <32000>, <44100>
> <48000>, <96000>, <176400>, <192000>;
> +               simple-audio-card,mclk-fs = <256>, <256>, <256>,
> <256>, <256>, <128>, <128>;
> 
> Let me know if this would be a good direction and I will send a patch.

Yes, actually I have noticed that current mclk-fs is not enough.
Above is nice idea to me. Thank you
One note is that we need to keep compatible