Re: [PATCH v4 6/9] ASoC: add snd_soc_get_dai_id()

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Linux-DT <devicetree@vger.kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
Subject: Re: [PATCH v4 6/9] ASoC: add snd_soc_get_dai_id()
Date: Mon, 10 Apr 2017 00:17:57 +0000	[thread overview]
Message-ID: <874lxx5dcd.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAL_JsqJrcG+zczxdjjBXU17EDGANR9Exet5h5R08dStXiV9zzg@mail.gmail.com>

Hi Rob

Thank you for your review.

> >> > +{
> >> > +       struct device_node *node;
> >> > +       struct device_node *endpoint;
> >> > +       int i, id;
> >> > +
> >> > +       node = of_graph_get_port_parent(ep);
> >> > +
> >> > +       i = 0;
> >> > +       id = -1;
> >> > +       for_each_endpoint_of_node(node, endpoint) {
> >> > +               if (endpoint == ep)
> >> > +                       id = i;
> >>
> >> I don't see how this works when you have 1 DAI controller with
> >> multiple endpoints versus multiple DAI controllers with a single
> >> endpoint each. All the IDs will be 0 in the latter case.
> >
> > It support 1:1 endpoint pattern only.
> 
> Then the endpoint id is always 0 and this function is pointless.

Sorry, I checked my patch-list, and I noticed that
this function will be expand to use callback function in next
patch-set (= HDMI support).
Thus, inded current function is pointless at this point.
I will merge this expansion patch in v5