Re: [PATCH] drm/i915: Remove bogus test for a present execbuffer

From: Eric Anholt <eric@anholt.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove bogus test for a present execbuffer
Date: Mon, 19 Nov 2012 08:42:59 -0800	[thread overview]
Message-ID: <874nkllf1o.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1353339042-23076-1-git-send-email-chris@chris-wilson.co.uk>

[-- Attachment #1.1: Type: text/plain, Size: 828 bytes --]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> The intention of checking obj->gtt_offset!=0 is to verify that the
> target object was listed in the execbuffer and had been bound into the
> GTT. This is guarranteed by the earlier rearrangement to split the
> execbuffer operation into reserve and relocation phases and then
> verified by the check that the target handle had been processed during
> the reservation phase.
>
> However, the actual checking of obj->gtt_offset==0 is bogus as we can
> indeed reference an object at offset 0. For instance, the framebuffer
> installed by the BIOS often resides at offset 0 - causing EINVAL as we
> legimately try to render using the stolen fb.

We've never triggered this check in practice, as far as I know, so I'm
happy to see it go.

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx