From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Li Qiong <liqiong@nfschina.com>,
Varka Bhadram <varkabhadram@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Yu Zhe <yuzhe@nfschina.com>
Subject: Re: [PATCH] ieee802154: cc2520: add rc code in cc2520_tx()
Date: Mon, 29 Aug 2022 10:55:31 +0200 [thread overview]
Message-ID: <8752aa54-28a3-9ae3-45ca-947551f31773@datenfreihafen.org> (raw)
In-Reply-To: <20220829071259.18330-1-liqiong@nfschina.com>
Hello Qiong.
On 29.08.22 09:12, Li Qiong wrote:
> The rc code is 0 at the error path "status & CC2520_STATUS_TX_UNDERFLOW".
> Assign rc code with '-EINVAL' at this error path to fix it.
>
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
> drivers/net/ieee802154/cc2520.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index 1e1f40f628a0..c69b87d3837d 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -504,6 +504,7 @@ cc2520_tx(struct ieee802154_hw *hw, struct sk_buff *skb)
> goto err_tx;
>
> if (status & CC2520_STATUS_TX_UNDERFLOW) {
> + rc = -EINVAL;
> dev_err(&priv->spi->dev, "cc2520 tx underflow exception\n");
> goto err_tx;
> }
This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!
regards
Stefan Schmidt
prev parent reply other threads:[~2022-08-29 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 7:12 [PATCH] ieee802154: cc2520: add rc code in cc2520_tx() Li Qiong
2022-08-29 8:55 ` Stefan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8752aa54-28a3-9ae3-45ca-947551f31773@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=varkabhadram@gmail.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.