From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Tim Chen <tim.c.chen@linux.intel.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
Wei Xu <weixugc@google.com>, Huang Ying <ying.huang@intel.com>,
Greg Thelen <gthelen@google.com>, Yang Shi <shy828301@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Brice Goglin <brice.goglin@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hesham Almatary <hesham.almatary@huawei.com>,
Dave Hansen <dave.hansen@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alistair Popple <apopple@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Feng Tang <feng.tang@intel.com>,
Jagdish Gediya <jvgediya@linux.ibm.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>
Subject: Re: [RFC PATCH 1/3] mm/memory-tiers Add functions for tier memory usage in a cgroup
Date: Tue, 21 Jun 2022 09:48:50 +0530 [thread overview]
Message-ID: <875ykuabth.fsf@linux.ibm.com> (raw)
In-Reply-To: <94a10c772c50d378b81dad654476551bfc50e3d7.1655242024.git.tim.c.chen@linux.intel.com>
Tim Chen <tim.c.chen@linux.intel.com> writes:
+unsigned long mem_cgroup_toptier_usage(struct mem_cgroup *memcg)
> +{
> + struct memory_tier *top_tier;
> +
> + top_tier = list_first_entry(&memory_tiers, struct memory_tier, list);
> + if (top_tier)
> + return mem_cgroup_memtier_usage(memcg, top_tier);
> + else
> + return 0;
> +}
As discussed here, we would want to consider all memory tiers that got
compute as top tier.
https://lore.kernel.org/linux-mm/11f94e0c50f17f4a6a2f974cb69a1ae72853e2be.camel@intel.com
V6 patchset actually walk the full memory tier hierarchy reverse and consider any
memory tier with higher or equal rank value than the first memory tier with CPU as top tier.
https://lore.kernel.org/linux-mm/20220610135229.182859-12-aneesh.kumar@linux.ibm.com
-aneesh
next prev parent reply other threads:[~2022-06-21 4:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 22:25 [RFC PATCH 0/3] Cgroup accounting of memory tier usage Tim Chen
2022-06-14 22:25 ` [RFC PATCH 1/3] mm/memory-tiers Add functions for tier memory usage in a cgroup Tim Chen
2022-06-21 4:18 ` Aneesh Kumar K.V [this message]
2022-06-23 23:07 ` Tim Chen
2022-06-14 22:25 ` [RFC PATCH 2/3] mm/memory-tiers: Use page counter to track toptier memory usage Tim Chen
2022-06-15 0:27 ` Wei Xu
2022-06-15 0:30 ` Wei Xu
2022-06-16 4:12 ` Tim Chen
2022-06-14 22:25 ` [RFC PATCH 3/3] mm/memory-tiers: Show toptier memory usage for cgroup Tim Chen
2022-06-15 4:58 ` [RFC PATCH 0/3] Cgroup accounting of memory tier usage Ying Huang
2022-06-15 17:47 ` Tim Chen
2022-06-15 11:11 ` Michal Hocko
2022-06-15 15:23 ` Tim Chen
2022-06-15 15:59 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ykuabth.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brice.goglin@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave@stgolabs.net \
--cc=feng.tang@intel.com \
--cc=gthelen@google.com \
--cc=hesham.almatary@huawei.com \
--cc=jvgediya@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=tim.c.chen@linux.intel.com \
--cc=weixugc@google.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.