Re: [PATCH] cifs: fix bad fids sent over wire

From: Paulo Alcantara <pc@cjr.nz>
To: Tom Talpey <tom@talpey.com>,
	linux-cifs@vger.kernel.org, smfrench@gmail.com
Subject: Re: [PATCH] cifs: fix bad fids sent over wire
Date: Mon, 21 Mar 2022 12:34:52 -0300	[thread overview]
Message-ID: <875yo7uxnn.fsf@cjr.nz> (raw)
In-Reply-To: <2962692d-a0b5-25f2-3053-7e21620639c9@talpey.com>

Tom Talpey <tom@talpey.com> writes:

> If you want to reduce a bit of code change, you could let the
> compiler generate the loads and stores via memcpy, with (perhaps)
> a struct { u8[8] } instead of the bare array.

Thanks for the suggestions.  It turned out to be more changes than I
expected.  In this case, I'm gonna fix some remaining sparse warnings
from my last patch and fix the commit message as you suggested.

Of course, we can refactor this out later and start with something like:

	struct smb2_fid {
	        __u8 Persistent[8];
	        __u8 Volatile[8];
	} __packed;

and then replace u64 integers with the above.