From: "Huang, Ying" <ying.huang@intel.com>
To: Yang Shi <shy828301@gmail.com>
Cc: dave.hansen@linux.intel.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: migrate: make demotion knob depend on migration
Date: Fri, 15 Oct 2021 09:42:19 +0800 [thread overview]
Message-ID: <875ytznjwk.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20211015005559.246709-1-shy828301@gmail.com> (Yang Shi's message of "Thu, 14 Oct 2021 17:55:59 -0700")
Yang Shi <shy828301@gmail.com> writes:
> The memory demotion needs to call migrate_pages() to do the jobs. And
> it is controlled by a knob, however, the knob doesn't depend on
> CONFIG_MIGRATION. The knob could be truned on even though MIGRATION is
> disabled, this will not cause any crash since migrate_pages() would just
> return -ENOSYS. But it is definitely not optimal to go through demotion
> path then retry regular swap every time.
>
> And it doesn't make too much sense to have the knob visible to the users
> when !MIGRATION. Move the related code from mempolicy.[h|c] to migrate.[h|c].
Sounds reasonable to me. Thanks!
> Signed-off-by: Yang Shi <shy828301@gmail.com>
Acked-by: "Huang, Ying" <ying.huang@intel.com>
Best Regards,
Huang, Ying
prev parent reply other threads:[~2021-10-15 1:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 0:55 [PATCH] mm: migrate: make demotion knob depend on migration Yang Shi
2021-10-15 1:42 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ytznjwk.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.