Re: [RFC v6 00/13] s390x cleanup

From: Cornelia Huck <cohuck@redhat.com>
To: "Cho, Yu-Chen" <acho@suse.com>,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: cfontana@suse.com, acho@suse.com, jose.ziviani@suse.com
Subject: Re: [RFC v6 00/13] s390x cleanup
Date: Wed, 30 Jun 2021 17:27:09 +0200	[thread overview]
Message-ID: <875yxvl6eq.fsf@redhat.com> (raw)
In-Reply-To: <20210629141931.4489-1-acho@suse.com>

On Tue, Jun 29 2021, "Cho, Yu-Chen" <acho@suse.com> wrote:

> this is the next version of a cleanup series for s390x.
>

(...)

> Cho, Yu-Chen (13):
>   target/s390x: meson: add target_user_arch
>   hw/s390x: rename tod-qemu.c to tod-tcg.c
>   hw/s390x: only build tod-tcg from the CONFIG_TCG build
>   hw/s390x: tod: make explicit checks for accelerators when initializing
>   target/s390x: remove tcg-stub.c
>   target/s390x: start moving TCG-only code to tcg/
>   target/s390x: move sysemu-only code out to cpu-sysemu.c
>   target/s390x: split cpu-dump from helper.c
>   target/s390x: make helper.c sysemu-only
>   target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m
>   target/s390x: remove kvm-stub.c
>   target/s390x: move kvm files into kvm/
>   target/s390x: split sysemu part of cpu models

I think this generally looks fine.

However, I'd like to have a second pair of eyes look at this, especially
at the cpu models.