From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 09/10] qom: Improve {qom,device}-list-properties error messages
Date: Fri, 13 Nov 2020 14:39:59 +0100 [thread overview]
Message-ID: <875z69fk9c.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <5501c86a-c016-ec9a-8069-96f5b0fadc76@redhat.com> (Paolo Bonzini's message of "Fri, 13 Nov 2020 10:09:07 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 13/11/20 09:26, Markus Armbruster wrote:
>> qom-list-properties reports
>> Parameter 'typename' expects device
>> when @typename exists, but isn't a TYPE_DEVICE. Improve this to
>> Parameter 'typename' expects a non-abstract device type
>> device-list-properties reports
>> Parameter 'typename' expects object
>> when @typename exists, but isn't a TYPE_OBJECT. Improve this to
>> Parameter 'typename' expects a QOM type
>
> Silly mistake: device-list-properties and qom-list-properties are
> exchanged in the commit message. Can be fixed without reposting.
You're right. Thanks!
next prev parent reply other threads:[~2020-11-13 13:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 8:26 [PATCH 00/10] Chipping away at qerror.h Markus Armbruster
2020-11-13 8:26 ` [PATCH 01/10] qerror: Drop unused QERR_ macros Markus Armbruster
2020-11-16 12:41 ` Philippe Mathieu-Daudé
2020-11-13 8:26 ` [PATCH 02/10] qerror: Eliminate QERR_ macros used in just one place Markus Armbruster
2020-11-13 8:26 ` [PATCH 03/10] block: Improve some block-commit, block-stream error messages Markus Armbruster
2020-11-13 13:30 ` Max Reitz
2020-11-13 8:26 ` [PATCH 04/10] ui: Improve some set_passwd, expire_password " Markus Armbruster
2020-11-13 8:26 ` [PATCH 05/10] ui: Improve a client_migrate_info error message Markus Armbruster
2020-11-13 8:26 ` [PATCH 06/10] ui: Tweak " Markus Armbruster
2020-11-13 8:26 ` [PATCH 07/10] qga: Replace an unreachable error by abort() Markus Armbruster
2020-11-13 8:26 ` [PATCH 08/10] qga: Tweak a guest-shutdown error message Markus Armbruster
2020-11-13 8:26 ` [PATCH 09/10] qom: Improve {qom, device}-list-properties error messages Markus Armbruster
2020-11-13 9:09 ` [PATCH 09/10] qom: Improve {qom,device}-list-properties " Paolo Bonzini
2020-11-13 13:39 ` Markus Armbruster [this message]
2020-11-13 8:26 ` [PATCH 10/10] Tweak a few "Parameter 'NAME' expects THING" error message Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z69fk9c.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.