From: "Alex Bennée" <alex.bennee@linaro.org>
To: Emilio Cota <cota@braap.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v2 3/5] thread: de-const qemu_spin_destroy
Date: Tue, 10 Jan 2023 09:09:22 +0000 [thread overview]
Message-ID: <877cxuoiwn.fsf@linaro.org> (raw)
In-Reply-To: <20230109224954.161672-4-cota@braap.org>
Emilio Cota <cota@braap.org> writes:
> Signed-off-by: Emilio Cota <cota@braap.org>
> ---
> include/qemu/thread.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/qemu/thread.h b/include/qemu/thread.h
> index 7c6703bce3..7841084199 100644
> --- a/include/qemu/thread.h
> +++ b/include/qemu/thread.h
> @@ -237,11 +237,10 @@ static inline void qemu_spin_init(QemuSpin *spin)
> #endif
> }
>
> -/* const parameter because the only purpose here is the TSAN annotation */
> -static inline void qemu_spin_destroy(const QemuSpin *spin)
> +static inline void qemu_spin_destroy(QemuSpin *spin)
> {
> #ifdef CONFIG_TSAN
> - __tsan_mutex_destroy((void *)spin, __tsan_mutex_not_static);
> + __tsan_mutex_destroy(spin, __tsan_mutex_not_static);
> #endif
> }
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-01-10 9:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:49 [PATCH v2 0/5] tsan fixes Emilio Cota
2023-01-09 22:49 ` [PATCH v2 1/5] cpu: free cpu->tb_jmp_cache with RCU Emilio Cota
2023-01-09 22:49 ` [PATCH v2 2/5] util/qht: add missing atomic_set(hashes[i]) Emilio Cota
2023-01-10 9:08 ` Alex Bennée
2023-01-09 22:49 ` [PATCH v2 3/5] thread: de-const qemu_spin_destroy Emilio Cota
2023-01-10 9:09 ` Alex Bennée [this message]
2023-01-09 22:49 ` [PATCH v2 4/5] util/qht: use striped locks under TSAN Emilio Cota
2023-01-10 20:58 ` Alex Bennée
2023-01-11 2:41 ` Emilio Cota
2023-01-11 13:03 ` Alex Bennée
2023-01-09 22:49 ` [PATCH v2 5/5] plugins: make qemu_plugin_user_exit's locking order consistent with fork_start's Emilio Cota
2023-01-10 7:31 ` Philippe Mathieu-Daudé
2023-01-10 12:55 ` [PATCH v2 0/5] tsan fixes Alex Bennée
2023-01-10 15:50 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cxuoiwn.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.