Re: [V1] Bluetooth: btusb: Add return error code

From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Youwan Wang <youwan@nfschina.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
	luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org
Subject: Re: [V1] Bluetooth: btusb: Add return error code
Date: Wed, 13 Mar 2024 08:18:56 +0100	[thread overview]
Message-ID: <877ebea0-1fc3-46d0-bebb-7f990e824931@molgen.mpg.de> (raw)
In-Reply-To: <20240313051102.424926-1-youwan@nfschina.com>

Dear Youwan,

Thank you for your patch. In the commit message summary/title maybe be 
more specific:

Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()

Am 13.03.24 um 06:11 schrieb Youwan Wang:
> Add return error code

Could you please elaborate and describe the problem?

> Signed-off-by: Youwan Wang <youwan@nfschina.com>
> ---
>   drivers/bluetooth/btusb.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index b8e9de887b5d..ec6bdc9687b1 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2826,8 +2826,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
>   		goto err_free_wc;
>   	}
>   
> -	if (data->evt_skb == NULL)
> +	if (data->evt_skb == NULL) {
> +		err = -ENOBUFS;
>   		goto err_free_wc;
> +	}
>   
>   	/* Parse and handle the return WMT event */
>   	wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;

Kind regards,

Paul