From: Jani Nikula <jani.nikula@intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL"
Date: Wed, 08 Mar 2017 16:53:58 +0200 [thread overview]
Message-ID: <877f3zizuh.fsf@intel.com> (raw)
In-Reply-To: <20170308143334.21216-1-ville.syrjala@linux.intel.com>
On Wed, 08 Mar 2017, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit bb10d4ec3be4b069bfb61c60ca4f708f58f440f1.
>
> Since commit c8ebfad7a063 ("drm/i915: Ignore OpRegion panel type except
> on select machines") we ignore the OpRegion panel type except for
> specific machines (handled via a DMI match), so having SKL explicitly
> excluded from using the OpRegion panel type is redundant. So let's
> remove the SKL check.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 4a862a358c70..2e870da8927a 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1061,16 +1061,5 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
> return -ENODEV;
> }
>
> - /*
> - * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us
> - * low vswing for eDP, whereas the VBT panel type (2) gives us normal
> - * vswing instead. Low vswing results in some display flickers, so
> - * let's simply ignore the OpRegion panel type on SKL for now.
> - */
> - if (IS_SKYLAKE(dev_priv)) {
> - DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> - return -ENODEV;
> - }
> -
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-08 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 14:33 [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL" ville.syrjala
2017-03-08 14:53 ` Jani Nikula [this message]
2017-03-14 10:25 ` Ville Syrjälä
2017-03-08 18:53 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-03-13 21:17 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f3zizuh.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.