Re: [PATCH] [RFC] drm/doc: Rename docbook to gpu.tmpl

From: Jani Nikula <jani.nikula@linux.intel.com>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] [RFC] drm/doc: Rename docbook to gpu.tmpl
Date: Wed, 07 Oct 2015 17:02:53 +0300	[thread overview]
Message-ID: <878u7e93oy.fsf@intel.com> (raw)
In-Reply-To: <1444204528-7870-1-git-send-email-daniel.vetter@ffwll.ch>

On Wed, 07 Oct 2015, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> DRM is a lot more than a direct manager nowadays, and there's also a
> bunch of things worth documenting for gpu driver developers outside of
> drivers/gpu/drm, like vgaarb, vga switcheroo or the various hardware
> buses like host1x and ipu-v3.
>
> To avoid further confusion let's rename the top-level to reflect
> reality.
>
> And yes I'm already looking forward to when we need to replace the G
> in GPU with a * ;-)
>
> Inspired by a thread with Lukas since he refused to include the vga
> switcheroo docs into the gpu docs because it's not drm.
>
> Cc: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  Documentation/DocBook/Makefile             |    4 +-
>  Documentation/DocBook/drm.tmpl             | 4129 ----------------------------
>  Documentation/DocBook/gpu.tmpl             | 4129 ++++++++++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    2 +
>  4 files changed, 4133 insertions(+), 4131 deletions(-)
>  delete mode 100644 Documentation/DocBook/drm.tmpl
>  create mode 100644 Documentation/DocBook/gpu.tmpl

Please use 'git format-patch -M' so it'll be easier to spot the little
easter egg at the end.

[tons of stuff removed]

> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 67ef118ee160..2c0d4dae3a35 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -1782,6 +1782,8 @@ i915_gem_execbuffer2(struct drm_device *dev, void *data,
>  	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
>  	int ret;
>  
> +	BUG();
> +

"whoops" ;)

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel