From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply
Date: 27 Feb 2020 11:34:47 +0900 [thread overview]
Message-ID: <87a7547o6w.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87blpk7psk.wl-kuninori.morimoto.gx@renesas.com>
Hi Pierre-Louis, again
> > Not in this case though, the initial idea was to do the mute when only
> > playback or capture were enabled? If you mute when both are enabled
> > then that's a real change.
>
> Let's check original
>
> if ((playback && playback_active == 1) ||
> (!playback && capture_active == 1))
> snd_soc_dai_digital_mute(...)
>
> It calls mute if Playback or Capture is working.
> and my patch (v2) is
>
> if (codec_dai->activity)
> snd_soc_dai_digital_mute(...)
>
> It calls mute if Codec DAI is working (= Playback or Capture).
> I think it doesn't change behavior.
Oops !
I was wrong. I will post mail to v2 patch for detail
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2020-02-27 2:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 6:39 [PATCH 0/8] ASoC: soc-pcm cleanup step5 Kuninori Morimoto
2020-02-26 6:39 ` [PATCH 1/8] ASoC: soc-pcm: use defined stream Kuninori Morimoto
2020-02-26 6:40 ` [PATCH 2/8] ASoC: soc-pcm: remove duplicate be check from dpcm_add_paths() Kuninori Morimoto
2020-02-26 6:40 ` [PATCH 3/8] ASoC: soc-pcm: move dpcm_fe_dai_close() Kuninori Morimoto
2020-02-26 6:40 ` [PATCH 4/8] ASoC: soc-pcm: add dpcm_fe_dai_clean() Kuninori Morimoto
2020-02-26 17:49 ` Ranjani Sridharan
2020-02-27 0:13 ` Kuninori Morimoto
2020-02-26 6:40 ` [PATCH 5/8] ASoC: soc-pcm: use snd_soc_dai_get_pcm_stream() at dpcm_set_fe_runtime() Kuninori Morimoto
2020-02-26 6:40 ` [PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply Kuninori Morimoto
2020-02-26 19:04 ` Pierre-Louis Bossart
2020-02-27 0:35 ` Kuninori Morimoto
2020-02-27 0:40 ` Pierre-Louis Bossart
2020-02-27 0:43 ` Kuninori Morimoto
2020-02-27 1:23 ` Pierre-Louis Bossart
2020-02-27 2:00 ` Kuninori Morimoto
2020-02-27 2:34 ` Kuninori Morimoto [this message]
2020-02-26 6:40 ` [PATCH 7/8] ASoC: soc-pcm: Do Digital Mute for both CPU/Codec in same timing Kuninori Morimoto
2020-02-26 6:41 ` [PATCH 8/8] ASoC: soc-pcm: tidyup dulicate handing at dpcm_fe_dai_startup() Kuninori Morimoto
2020-02-26 15:22 ` Pierre-Louis Bossart
2020-02-27 0:04 ` Kuninori Morimoto
2020-02-26 15:24 ` [PATCH 0/8] ASoC: soc-pcm cleanup step5 Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7547o6w.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.