From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev8)
Date: Tue, 21 Jan 2020 11:25:51 +0200 [thread overview]
Message-ID: <87a76hf9eo.fsf@intel.com> (raw)
In-Reply-To: <157951691186.679.1929122645769239737@emeril.freedesktop.org>
Thomas, please fix the sparse/build warnings.
BR,
Jani.
On Mon, 20 Jan 2020, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev8)
> URL : https://patchwork.freedesktop.org/series/71873/
> State : warning
>
> == Summary ==
>
> $ dim sparse origin/drm-tip
> Sparse version: v0.6.0
> Commit: drm: Remove internal setup of struct drm_device.vblank_disable_immediate
> Okay!
>
> Commit: drm: Add get_scanout_position() to struct drm_crtc_helper_funcs
> Okay!
>
> Commit: drm: Add get_vblank_timestamp() to struct drm_crtc_funcs
> + ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +drivers/gpu/drm/drm_vblank.c:1869:19: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
> +drivers/gpu/drm/drm_vblank.c: In function ‘drm_handle_vblank_events’:
> + high_prec = crtc && crtc->funcs->get_vblank_timestamp ||
>
> Commit: drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()
> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5057:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static?
> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5058:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static?
> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8393:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static?
> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8397:50: warning: missing braces around initializer
> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8394:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static?
> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8398:50: warning: missing braces around initializer
>
> Commit: drm/amdgpu: Convert to CRTC VBLANK callbacks
> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5058:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static?
> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5060:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static?
> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8394:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static?
> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8398:50: warning: missing braces around initializer
> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8396:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static?
> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8400:50: warning: missing braces around initializer
>
> Commit: drm/gma500: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/i915: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()
> Okay!
>
> Commit: drm/nouveau: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()
> Okay!
>
> Commit: drm/radeon: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()
> Okay!
>
> Commit: drm/msm: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()
> Okay!
>
> Commit: drm/stm: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/sti: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position()
> Okay!
>
> Commit: drm/vc4: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/vkms: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm/vmwgfx: Convert to CRTC VBLANK callbacks
> Okay!
>
> Commit: drm: Clean-up VBLANK-related callbacks in struct drm_driver
> - ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> -drivers/gpu/drm/drm_vblank.c: In function ‘drm_handle_vblank_events’:
> - high_prec = crtc && crtc->funcs->get_vblank_timestamp ||
> -O:drivers/gpu/drm/drm_vblank.c:1869:19: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
>
> Commit: drm: Remove legacy version of get_scanout_position()
> Okay!
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-21 9:26 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 8:22 [PATCH v3 00/22] drm: Clean up VBLANK callbacks in struct drm_driver Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [PATCH v3 01/22] drm: Remove internal setup of struct drm_device.vblank_disable_immediate Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [PATCH v3 02/22] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [PATCH v3 03/22] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 15:38 ` [Intel-gfx] " Ville Syrjälä
2020-01-20 15:38 ` Ville Syrjälä
2020-01-20 15:38 ` Ville Syrjälä
2020-01-20 15:38 ` Ville Syrjälä
2020-01-20 15:38 ` Ville Syrjälä
2020-01-20 8:22 ` [PATCH v3 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [PATCH v3 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [PATCH v3 06/22] drm/gma500: " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 12:32 ` Patrik Jakobsson
2020-01-20 12:32 ` Patrik Jakobsson
2020-01-20 12:32 ` [Intel-gfx] " Patrik Jakobsson
2020-01-20 12:32 ` Patrik Jakobsson
2020-01-20 12:32 ` Patrik Jakobsson
2020-01-20 8:22 ` [PATCH v3 07/22] drm/i915: " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:22 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:22 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 11/22] drm/radeon: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 12/22] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 13/22] drm/msm: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 15/22] drm/stm: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 16/22] drm/sti: " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 17/22] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position() Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 18/22] drm/vc4: Convert to CRTC VBLANK callbacks Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 19/22] drm/vkms: " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 20/22] drm/vmwgfx: " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 12:15 ` Thomas Hellstrom
2020-01-20 12:15 ` Thomas Hellstrom
2020-01-20 12:15 ` [Intel-gfx] " Thomas Hellstrom
2020-01-20 12:15 ` Thomas Hellstrom
2020-01-20 12:15 ` Thomas Hellstrom
2020-01-20 8:23 ` [PATCH v3 21/22] drm: Clean-up VBLANK-related callbacks in struct drm_driver Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [PATCH v3 22/22] drm: Remove legacy version of get_scanout_position() Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 8:23 ` [Intel-gfx] " Thomas Zimmermann
2020-01-20 8:23 ` Thomas Zimmermann
2020-01-20 15:40 ` Ville Syrjälä
2020-01-20 15:40 ` Ville Syrjälä
2020-01-20 15:40 ` [Intel-gfx] " Ville Syrjälä
2020-01-20 15:40 ` Ville Syrjälä
2020-01-20 15:40 ` Ville Syrjälä
2020-01-20 10:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev8) Patchwork
2020-01-20 10:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-01-21 9:25 ` Jani Nikula [this message]
2020-01-21 9:54 ` Thomas Zimmermann
2020-01-21 15:51 ` Jani Nikula
2020-01-20 12:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a76hf9eo.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.