From: Markus Armbruster <armbru@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Lukas Straub <lukasstraub2@web.de>,
qemu-devel@nongnu.org
Subject: Re: [PULL 0/7] Yank patches patches for 2021-01-13
Date: Thu, 14 Jan 2021 13:40:52 +0100 [thread overview]
Message-ID: <87bldrsncb.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87r1mnlr0a.fsf@linaro.org> ("Alex =?utf-8?Q?Benn=C3=A9e=22's?= message of "Thu, 14 Jan 2021 11:02:20 +0000")
Alex Bennée <alex.bennee@linaro.org> writes:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On Wed, 13 Jan 2021 at 09:31, Markus Armbruster <armbru@redhat.com> wrote:
>>>
>>> This pull request is on behalf of Lukas. Hope that's okay.
>>>
>>> The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0:
>>>
>>> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210112-1' into staging (2021-01-12 21:23:25 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://repo.or.cz/qemu/armbru.git tags/pull-yank-2021-01-13
>>>
>>> for you to fetch changes up to 91d48e520a4a4f72e97aeb333029694f5d57cc93:
>>>
>>> tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test (2021-01-13 10:21:17 +0100)
>>>
>>> ----------------------------------------------------------------
>>> Yank patches patches for 2021-01-13
>>>
>>> ----------------------------------------------------------------
>>> Lukas Straub (7):
>>> Introduce yank feature
>>> block/nbd.c: Add yank feature
>>> chardev/char-socket.c: Add yank feature
>>> migration: Add yank feature
>>> io/channel-tls.c: make qio_channel_tls_shutdown thread-safe
>>> io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown
>>> tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test
>>
>>
>> Applied, thanks.
>
> This broke the check-unit and check-softfloat build task in Travis
>
> https://travis-ci.org/github/qemu/qemu/jobs/754436018
>
> Likely because of missing stubs for the yank commands:
>
> FAILED: qemu-io
>
> gcc -o qemu-io qemu-io.p/qemu-io.c.o -Wl,--as-needed -Wl,--no-undefined -pie -Wl,--whole-archive libblock.fa libcrypto.fa libauthz.fa libqom.fa libio.fa -Wl,--no-whole-archive -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -m64 -fstack-protector-strong -Wl,--start-group libqemuutil.a subprojects/libvhost-user/libvhost-user-glib.a subprojects/libvhost-user/libvhost-user.a libblock.fa libcrypto.fa libauthz.fa libqom.fa libio.fa @block.syms -lgnutls -pthread -lutil -lm -lgthread-2.0 -lglib-2.0 -lgthread-2.0 -lglib-2.0 -lxml2 /usr/lib/x86_64-linux-gnu/libiscsi.so -laio -lgthread-2.0 -lglib-2.0 /usr/lib/x86_64-linux-gnu/libz.so /usr/lib/x86_64-linux-gnu/libnfs.so /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libzstd.so -lssh /usr/lib/x86_64-linux-gnu/libcurl.so /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libbz2.so -lgnutls -lnettle -lgnutls -lpam -lgnutls -Wl,--end-group
>
> /usr/bin/ld: libblock.fa(block_nbd.c.o): in function `nbd_close':
>
> /home/travis/build/qemu/qemu/build/../block/nbd.c:2358: undefined reference to `yank_unregister_instance'
[...]
> collect2: error: ld returned 1 exit status
Reproduced locally:
$ ../configure --disable-system --disable-user --enable-tools
$ make
Lukas, can you take care of this?
next prev parent reply other threads:[~2021-01-14 12:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 9:30 [PULL 0/7] Yank patches patches for 2021-01-13 Markus Armbruster
2021-01-13 9:30 ` [PULL 1/7] Introduce yank feature Markus Armbruster
2021-01-13 9:30 ` [PULL 2/7] block/nbd.c: Add " Markus Armbruster
2021-01-13 9:30 ` [PULL 3/7] chardev/char-socket.c: " Markus Armbruster
2021-01-13 9:30 ` [PULL 4/7] migration: " Markus Armbruster
2021-01-13 9:30 ` [PULL 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe Markus Armbruster
2021-01-13 9:31 ` [PULL 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown Markus Armbruster
2021-01-13 9:31 ` [PULL 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test Markus Armbruster
2021-01-13 15:53 ` [PULL 0/7] Yank patches patches for 2021-01-13 Peter Maydell
2021-01-13 16:25 ` Markus Armbruster
2021-01-13 17:26 ` Lukas Straub
2021-01-14 11:02 ` Alex Bennée
2021-01-14 12:40 ` Markus Armbruster [this message]
2021-01-14 12:44 ` Lukas Straub
2021-01-14 13:19 ` [PATCH] Fix build with new yank feature by adding stubs Lukas Straub
2021-01-14 13:46 ` Alex Bennée
2021-01-14 14:04 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bldrsncb.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=lukasstraub2@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.