From: Jani Nikula <jani.nikula@intel.com>
To: Scot Doyle <lkml14@scotdoyle.com>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Tyler Cleveland <siralucardt@openmailbox.org>
Subject: Re: [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U)
Date: Tue, 26 Aug 2014 15:21:11 +0300 [thread overview]
Message-ID: <87bnr7l9vs.fsf@intel.com> (raw)
In-Reply-To: <alpine.LNX.2.11.1408211604320.2057@localhost.localdomain>
On Thu, 21 Aug 2014, Scot Doyle <lkml14@scotdoyle.com> wrote:
> commit c675949ec58ca50d5a3ae3c757892f1560f6e896
> drm/i915: do not setup backlight if not available according to VBT
>
> prevents backlight setup on the Acer C720 (Core i3 4005U CPU), which has a
> misconfigured VBT. Apply quirk to ignore the VBT backlight presence check
> during backlight setup.
>
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> Tested-by: Tyler Cleveland <siralucardt@openmailbox.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed to drm-intel-fixes, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 0b327eb..3d4a4eb 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12553,6 +12553,9 @@ static struct intel_quirk intel_quirks[] = {
> /* Acer C720 and C720P Chromebooks (Celeron 2955U) have backlights */
> { 0x0a06, 0x1025, 0x0a11, quirk_backlight_present },
>
> + /* Acer C720 Chromebook (Core i3 4005U) */
> + { 0x0a16, 0x1025, 0x0a11, quirk_backlight_present },
> +
> /* Toshiba CB35 Chromebook (Celeron 2955U) */
> { 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>
> --
> 1.7.10.4
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-08-26 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 16:08 [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U) Scot Doyle
2014-08-26 12:21 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnr7l9vs.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lkml14@scotdoyle.com \
--cc=siralucardt@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.