From: Paulo Alcantara <pc@cjr.nz>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [CIFS][PATCH] Clarify SMB1 code for delete
Date: Wed, 07 Jul 2021 13:27:02 -0300 [thread overview]
Message-ID: <87czru5bu1.fsf@cjr.nz> (raw)
In-Reply-To: <CAH2r5mudi2+JF---Ou_8eojmH0f8o7Fz2NejuNvFmPaLPCbUww@mail.gmail.com>
Steve French <smfrench@gmail.com> writes:
> Coverity also complains about the way we calculate the offset
> (starting from the address of a 4 byte array within the
> header structure rather than from the beginning of the struct
> plus 4 bytes) for SMB1 SetFileDisposition (which is used to
> unlink a file by setting the delete on close flag). This
> changeset doesn't change the address but makes it slightly
> clearer.
>
> Addresses-Coverity: 711524 ("Out of bounds write")
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
> fs/cifs/cifssmb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
prev parent reply other threads:[~2021-07-07 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 2:46 [CIFS][PATCH] Clarify SMB1 code for delete Steve French
2021-07-07 16:27 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czru5bu1.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.