From: Stefan Schmidt <stefan@datenfreihafen.org>
To: David Miller <davem@davemloft.net>, yuehaibing@huawei.com
Cc: h.morris@cascoda.com, alex.aring@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done
Date: Tue, 11 Dec 2018 09:26:37 +0100 [thread overview]
Message-ID: <87dbac94-8b2e-8cef-5166-8c130529ceb9@datenfreihafen.org> (raw)
In-Reply-To: <20181210.220107.751606140724107779.davem@davemloft.net>
Hello Dave.
On 11.12.18 07:01, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Tue, 11 Dec 2018 11:13:39 +0800
>
>> gcc warning this:
>>
>> drivers/net/ieee802154/ca8210.c:730:10: warning:
>> comparison is always false due to limited range of data type [-Wtype-limits]
>>
>> 'len' is u8 type, we get it from buf[1] adding 2, which can overflow.
>> This patch change the type of 'len' to unsigned int to avoid this,also fix
>> the gcc warning.
>>
>> Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> WPAN maintainers, I am assuming that as maintainers you will be
> picking this up and sending it to me.
That's correct. On driver patches I always wait 2 days or so to give the
driver maintainer a chance to reply before I go ahead and apply it.
I will take this one directly now and do some smoke testing. It will
come together with another fix as pull request to you.
regards
Stefan Schmidt
next prev parent reply other threads:[~2018-12-11 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 3:13 [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done YueHaibing
2018-12-11 3:13 ` YueHaibing
2018-12-11 6:01 ` David Miller
2018-12-11 8:26 ` Stefan Schmidt [this message]
2018-12-11 15:23 ` Alexander Aring
2018-12-11 8:39 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87dbac94-8b2e-8cef-5166-8c130529ceb9@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=h.morris@cascoda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.