From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: guochun.mao@mediatek.com, Mark Brown <broonie@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Zhen Zhang <zhen.zhang@mediatek.com>,
Bayi Cheng <bayi.cheng@mediatek.com>,
Chuanhong Guo <gch981213@gmail.com>,
Bin Zhang <bin.zhang@mediatek.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
project_global_chrome_upstream_group@mediatek.com
Subject: Re: [PATCH v2 2/4] spi: spi-mtk-nor: improve device table for adding more capabilities
Date: Tue, 18 Jan 2022 15:52:44 +0100 [thread overview]
Message-ID: <87dceb69-99f7-e730-490a-f8e792c807ac@collabora.com> (raw)
In-Reply-To: <20220118142820.2729-3-guochun.mao@mediatek.com>
Il 18/01/22 15:28, guochun.mao@mediatek.com ha scritto:
> From: Guochun Mao <guochun.mao@mediatek.com>
>
> Define a structure for adding more capabilities.
> Add a item extra_dummy_bit for new SoCs, due to design changed.
>
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> Signed-off-by: Zhen Zhang <zhen.zhang@mediatek.com>
> ---
> drivers/spi/spi-mtk-nor.c | 48 +++++++++++++++++++++++++++++++--------
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c
> index 5c93730615f8..f5ff01f61f42 100644
> --- a/drivers/spi/spi-mtk-nor.c
> +++ b/drivers/spi/spi-mtk-nor.c
> @@ -95,6 +95,17 @@
>
> #define CLK_TO_US(sp, clkcnt) DIV_ROUND_UP(clkcnt, sp->spi_freq / 1000000)
>
> +struct mtk_nor_caps {
> + u8 dma_bits;
> +
> + /* extra_dummy_bit is adding for the IP of new SoCs.
> + * Some new SoCs modify the timing of fetching registers' values
> + * and IDs of nor flash, they need a extra_dummy_bit which can add
> + * more clock cycles for fetching data.
> + */
Thank you for this explaination. That was much appreciated.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-01-18 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 14:28 [PATCH v2 0/4] add new SoC mt8186 support for spi-mtk-nor guochun.mao
2022-01-18 14:28 ` [PATCH v2 1/4] dt-bindings: spi: add mt8186-nor compatible string guochun.mao
2022-01-18 14:28 ` [PATCH v2 2/4] spi: spi-mtk-nor: improve device table for adding more capabilities guochun.mao
2022-01-18 14:52 ` AngeloGioacchino Del Regno [this message]
2022-01-19 1:40 ` Guochun Mao
2022-01-18 14:28 ` [PATCH v2 3/4] spi: spi-mtk-nor: add new soc mt8186 support guochun.mao
2022-01-18 14:53 ` AngeloGioacchino Del Regno
2022-01-18 14:28 ` [PATCH v2 4/4] spi: spi-mtk-nor: add axi_s clock for mt8186 guochun.mao
2022-01-25 10:21 ` [PATCH v2 0/4] add new SoC mt8186 support for spi-mtk-nor Mark Brown
2022-01-25 10:58 ` Guochun Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87dceb69-99f7-e730-490a-f8e792c807ac@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=bayi.cheng@mediatek.com \
--cc=bin.zhang@mediatek.com \
--cc=broonie@kernel.org \
--cc=gch981213@gmail.com \
--cc=guochun.mao@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=project_global_chrome_upstream_group@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=zhen.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.