From: Vladimir Zapolskiy <vz@mleia.com>
To: Dario Binacchi <dariobin@libero.it>, linux-kernel@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
Drew Fustini <drew@beagleboard.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file
Date: Fri, 21 May 2021 09:44:06 +0300 [thread overview]
Message-ID: <87ea9971-9e15-c595-95cc-14c68b0b68d8@mleia.com> (raw)
In-Reply-To: <20210520202730.4444-3-dariobin@libero.it>
Hello Dario,
On 5/20/21 11:27 PM, Dario Binacchi wrote:
> The MPUs of some architectures (e.g AM335x) must be in privileged
> operating mode to write on the pinmux registers. In such cases, where
> writes will not work from user space, now it can be done from the pins
user space has no connection to the problem you're trying to solve.
Please provide a reasonable rationale for adding a new interface, thank
you in advance.
> debug file if the platform driver exports the pin_dbg_set() helper among
> the registered operations.
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
I strongly object against this new interface.
As Andy've already mentioned you have to operate with defined pin groups
and functions, and so far you create an interface with an option to
disasterous misusage, it shall be avoided, because there are better
options.
What's the issue with a regular declaration of pin groups and functions
on your SoC? When it's done, you can operate on this level of abstraction,
there is absolutely no need to add the proposed low-level debug interface.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2021-05-21 6:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 20:27 [PATCH v3 0/3] am335x: set pinmux registers from pins debug file Dario Binacchi
2021-05-20 20:27 ` Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 1/3] docs/pinctrl: update `pins' description under debugfs Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file Dario Binacchi
2021-05-21 6:44 ` Vladimir Zapolskiy [this message]
2021-05-24 17:28 ` Dario Binacchi
2021-05-24 18:52 ` Vladimir Zapolskiy
2021-05-25 5:15 ` Tony Lindgren
2021-05-27 19:23 ` Dario Binacchi
2021-05-27 19:57 ` Vladimir Zapolskiy
2021-05-27 20:33 ` Dario Binacchi
2021-05-28 8:34 ` Vladimir Zapolskiy
2021-05-28 9:07 ` Linus Walleij
2021-06-02 5:03 ` Tony Lindgren
2021-06-11 8:29 ` Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 3/3] pinctrl: single: set " Dario Binacchi
2021-05-20 20:27 ` Dario Binacchi
2021-05-21 6:44 ` Vladimir Zapolskiy
2021-05-21 6:44 ` Vladimir Zapolskiy
2021-05-25 0:18 ` [PATCH v3 0/3] am335x: set pinmux registers " Linus Walleij
2021-05-25 0:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ea9971-9e15-c595-95cc-14c68b0b68d8@mleia.com \
--to=vz@mleia.com \
--cc=andy.shevchenko@gmail.com \
--cc=dariobin@libero.it \
--cc=drew@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.