Re: [alsa-devel] [PATCH 9/9] ASoC: soc-core: call snd_soc_dapm_shutdown() at soc_cleanup_card_resources()

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: "Sridharan, Ranjani" <ranjani.sridharan@intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH 9/9] ASoC: soc-core: call snd_soc_dapm_shutdown() at soc_cleanup_card_resources()
Date: 06 Nov 2019 11:56:06 +0900	[thread overview]
Message-ID: <87eeylhfw9.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAFQqKeXx9rXj3b0monvJ6CrBj9B0YCzwcAUc2SH7ya9yb9mjnA@mail.gmail.com>

Hi Ranjani

Thank you for your feedback

>     Do you mean [7/9] patch ?
>     It merges snd_soc_instantiate_card() and snd_soc_bind_card().
>     Thus, snd_soc_bind_card() is still exist.
>     Or am I misunderstanding ?
> 
> Oh yes, sorry I misread that. So why not remove cleanup_card_resources and move everything to snd_soc_unbind_card()?

Good question :)

Indeed snd_soc_bind_card() and snd_soc_unbind_card() are paired function.
We want to merge cleanup_card_resources() and snd_soc_unbind_card().
But, can you check snd_soc_unbind_card() ?
unbind() is caring
	- card->instantiated
	- snd_soc_flush_all_delayed_work(card);
	- unbind_card_list

Actually I tried to merge cleanup() and unbind() into one,
but then, the code became not simple.
So I gave up this time.
But, we might can do it in the future if soc-core is more cleanuped/simpled.

Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel