From: NeilBrown <neilb@suse.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"axboe@fb.com" <axboe@fb.com>
Subject: Re: [PATCH v2 1/3] badblocks: Add core badblock management code
Date: Wed, 09 Dec 2015 08:03:05 +1100 [thread overview]
Message-ID: <87egewslfa.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1449273524.16905.103.camel@intel.com>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On Sat, Dec 05 2015, Verma, Vishal L wrote:
>>
>> > +int badblocks_clear(struct badblocks *bb, sector_t s, int sectors)
>> > +{
>> [...]
>> > +#define DO_DEBUG 1
>>
>> Why have this at all if it's unconditionally defined and always set.
>
> Neil - any reason or anything you had in mind for this? Or is it just an
> artifact and can be removed.
Like the comment says:
/* Allow clearing via sysfs *only* for testing/debugging.
* Normally only a successful write may clear a badblock
*/
The DO_DEBUG define and ifdefs are documentation identifying bits of
code that should be removed when it all seems to be working.
Maybe now is a good time to remove that code.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-12-08 21:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 18:43 [PATCH v2 0/3] Badblock tracking for gendisks Vishal Verma
2015-11-25 18:43 ` [PATCH v2 1/3] badblocks: Add core badblock management code Vishal Verma
2015-12-04 23:30 ` James Bottomley
2015-12-04 23:58 ` Verma, Vishal L
2015-12-05 0:06 ` James Bottomley
2015-12-05 0:11 ` Verma, Vishal L
2015-12-08 21:03 ` NeilBrown [this message]
2015-12-08 21:08 ` Verma, Vishal L
2015-12-08 21:18 ` Dan Williams
2015-12-08 23:47 ` Verma, Vishal L
2015-12-22 5:34 ` NeilBrown
2015-12-22 22:13 ` Verma, Vishal L
2015-12-22 23:06 ` NeilBrown
2015-12-23 0:38 ` Verma, Vishal L
2015-11-25 18:43 ` [PATCH v2 2/3] block: Add badblock management for gendisks Vishal Verma
2015-12-04 23:33 ` James Bottomley
2015-12-05 0:17 ` Verma, Vishal L
2015-11-25 18:43 ` [PATCH v2 3/3] md: convert to use the generic badblocks code Vishal Verma
2015-12-01 18:55 ` Shaohua Li
2015-12-01 19:52 ` Verma, Vishal L
2015-12-04 22:53 ` [PATCH v2 0/3] Badblock tracking for gendisks Verma, Vishal L
2015-12-08 2:52 Vishal Verma
2015-12-08 2:52 ` [PATCH v2 1/3] badblocks: Add core badblock management code Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egewslfa.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.